Define login nodes using an opentofu module #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bull
requested changes
Jan 23, 2025
environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
Outdated
Show resolved
Hide resolved
m-bull
reviewed
Jan 23, 2025
environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
Outdated
Show resolved
Hide resolved
m-bull
approved these changes
Jan 23, 2025
bertiethorpe
pushed a commit
that referenced
this pull request
Jan 29, 2025
* define login nodes using tf module * Apply suggestions from code review Co-authored-by: Matt Anson <[email protected]> * tweak README to explain compute groups * try to clarify login/compute groups --------- Co-authored-by: Matt Anson <[email protected]>
sjpb
added a commit
that referenced
this pull request
Feb 11, 2025
* add rebuild role to appliance and modify groupvars * improve readability of group_vars * Define login nodes using an opentofu module (#547) * define login nodes using tf module * Apply suggestions from code review Co-authored-by: Matt Anson <[email protected]> * tweak README to explain compute groups * try to clarify login/compute groups --------- Co-authored-by: Matt Anson <[email protected]> * Change docs/ references from Terraform to OpenTofu (#544) * change terraform references to opentofu in docs * remove wider reference to terraform * Update environments/README.md Co-authored-by: Steve Brasier <[email protected]> * Update environments/common/README.md Co-authored-by: Steve Brasier <[email protected]> --------- Co-authored-by: Steve Brasier <[email protected]> * fix instance_id in compute inventory to be target image, not deployed image * review all roles for compute_init_enable * fix permissions to /exports/cluster * make openhpc_config more greppable * Set ResumeTimeout and ReturnToService overrides in group_vars * CI tests for reboot via slurm (without rebuild) * fpinrocky 8 pythoolsvenv version * refining comments and task names * rebuild role readme --------- Co-authored-by: Steve Brasier <[email protected]> Co-authored-by: Matt Anson <[email protected]> Co-authored-by: Steve Brasier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the definition of login nodes in the opentofu variables to match the approach used for compute nodes.
This simplifies the opentofu configurations, allows more flexibility in login node definition, and will allow adding multiple networks in subsequent work.