Skip to content

Support multiple networks in OpenTofu configurations #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 22, 2025

Replaces opentofu variables cluster_net and cluster_subnet with new cluster_networks taking a list of mappings. How vnic properties are defined has changed to suit. Additional networks can be attached to compute and login node groups via an extra_networks parameter. Note this means at least the first network in cluster_networks will span all nodes - this is a requirement.

Also adds docs/networks.md describing supported configurations.

@sjpb sjpb requested a review from a team as a code owner January 22, 2025 17:14
@sjpb sjpb changed the base branch from main to feat/tf-login-module January 23, 2025 09:49
Base automatically changed from feat/tf-login-module to main January 23, 2025 13:17
@sjpb sjpb force-pushed the feat/tf-multiple-networks branch from 54165a4 to 652edb1 Compare January 23, 2025 13:18
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems pretty good. I've some general docs comments, but they might be due to my misunderstanding of how things are supposed to work...

@sjpb sjpb requested a review from m-bull January 24, 2025 12:10
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nit to possibly tighten the language around the access network and internet access, but otherwise this looks great now.

@sjpb sjpb merged commit eb216df into main Jan 29, 2025
2 checks passed
@sjpb sjpb deleted the feat/tf-multiple-networks branch January 29, 2025 16:30
priteau added a commit that referenced this pull request Feb 5, 2025
sjpb pushed a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants