-
Notifications
You must be signed in to change notification settings - Fork 34
Support multiple networks in OpenTofu configurations #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54165a4
to
652edb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems pretty good. I've some general docs comments, but they might be due to my misunderstanding of how things are supposed to work...
Co-authored-by: Matt Anson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final nit to possibly tighten the language around the access network and internet access, but otherwise this looks great now.
This follows changes made in #548.
This follows changes made in #548.
Replaces opentofu variables
cluster_net
andcluster_subnet
with newcluster_networks
taking a list of mappings. How vnic properties are defined has changed to suit. Additional networks can be attached to compute and login node groups via anextra_networks
parameter. Note this means at least the first network incluster_networks
will span all nodes - this is a requirement.Also adds
docs/networks.md
describing supported configurations.