Skip to content

avoid tf updates to login/compute on control delete/recreate #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 29, 2025

Uses the control node port to derive the control node IP instead of the control node's access_ip property. This avoids opentofu showing an update is required for the login + compute nodes because of metadata being "known after apply" when changes (e.g. image changes) mean the control node will be deleted and recreated. Works because the first cluster_network is always the access network on the control node, by definition.

Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 25a1ebd into main Jan 30, 2025
2 checks passed
@sjpb sjpb deleted the fix/update-compute-metadata-v2 branch January 30, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants