Skip to content

Support memory limits and pam no-login in compute-init #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

Support memory limits and pam no-login in compute-init #568

merged 3 commits into from
Feb 12, 2025

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Feb 11, 2025 •
edited by sjpb
Loading

  • Set locked memory limits on user-facing nodes
  • Block ssh to compute nodes for non-privileged users without running jobs

NB: No image build was completed with this PR - image changes MUST be picked up later before a release.

@bertiethorpe bertiethorpe requested a review from a team as a code owner February 11, 2025 09:45
@sjpb sjpb changed the title Add missing slurm.yml playbook tasks to compute-init Support memory limits and pam no-login in compute-init Feb 11, 2025
sjpb
sjpb requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment •
edited by bertiethorpe
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this in the same order as in slurm.yml please?

@bertiethorpe bertiethorpe requested a review from sjpb February 11, 2025 13:41
sjpb
sjpb approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit b35f61c into main Feb 12, 2025
2 checks passed
@sjpb sjpb deleted the feat/compute-init-extras branch February 12, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertiethorpe @sjpb