Skip to content

Support tuned in compute-init #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ansible/bootstrap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@
ansible.builtin.assert:
that: dnf_repos_password is undefined
fail_msg: Passwords should not be templated into repofiles during configure, unset 'dnf_repos_password'
when: appliances_mode == 'configure'
when:
- appliances_mode == 'configure'
- not (dnf_repos_allow_insecure_creds | default(false)) # useful for development

- hosts: squid
tags: squid
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/compute_init/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ it also requires an image build with the role name added to the
| bootstrap.yml | sshd | None at present | No |
| bootstrap.yml | dnf_repos | None at present [2] | - |
| bootstrap.yml | squid | Not relevant for compute nodes | n/a |
| bootstrap.yml | tuned | None | - |
| bootstrap.yml | tuned | Fully supported | No |
| bootstrap.yml | freeipa_server | Not relevant for compute nodes | n/a |
| bootstrap.yml | cockpit | None required - use image build | No |
| bootstrap.yml | firewalld | Not relevant for compute nodes | n/a |
Expand Down
15 changes: 13 additions & 2 deletions ansible/roles/compute_init/files/compute-init.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
enable_compute: "{{ os_metadata.meta.compute | default(false) | bool }}"
enable_resolv_conf: "{{ os_metadata.meta.resolv_conf | default(false) | bool }}"
enable_etc_hosts: "{{ os_metadata.meta.etc_hosts | default(false) | bool }}"
enable_tuned: "{{ os_metadata.meta.tuned | default(false) | bool }}"
enable_nfs: "{{ os_metadata.meta.nfs | default(false) | bool }}"
enable_manila: "{{ os_metadata.meta.manila | default(false) | bool }}"
enable_basic_users: "{{ os_metadata.meta.basic_users | default(false) | bool }}"
Expand All @@ -17,6 +18,12 @@
# TODO: "= role defaults" - could be moved to a vars_file: on play with similar precedence effects
resolv_conf_nameservers: []

tuned_profile_baremetal: hpc-compute
tuned_profile_vm: virtual-guest
tuned_profile: "{{ tuned_profile_baremetal if ansible_virtualization_role != 'guest' else tuned_profile_vm }}"
tuned_enabled: true
tuned_started: true

nfs_client_mnt_point: "/mnt"
nfs_client_mnt_options:
nfs_client_mnt_state: mounted
Expand Down Expand Up @@ -59,9 +66,9 @@
file:
path: /mnt/cluster
state: directory
owner: root
owner: slurm
group: root
mode: u=rwX,go= # is sensitive
mode: u=rX,g=rwX,o=

- name: Mount /mnt/cluster
mount:
Expand Down Expand Up @@ -125,6 +132,10 @@
mode: 0644
when: enable_etc_hosts

- name: Configure tuned
include_tasks: tasks/tuned.yml
when: enable_tuned

# NFS client mount
- name: If nfs-clients is present
include_tasks: tasks/nfs-clients.yml
Expand Down
2 changes: 2 additions & 0 deletions ansible/roles/compute_init/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
dest: files/NetworkManager-dns-none.conf
- src: ../../basic_users/filter_plugins/filter_keys.py
dest: filter_plugins/filter_keys.py
- src: ../../tuned/tasks/configure.yml
dest: tasks/tuned.yml
- src: ../../stackhpc.nfs/tasks/nfs-clients.yml
dest: tasks/nfs-clients.yml

Expand Down
4 changes: 4 additions & 0 deletions environments/.stackhpc/inventory/extra_groups
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ cluster
login
compute

[tuned:children]
# Install tuned into fat image
builder

[squid:children]
# Install squid into fat image
builder
Expand Down
4 changes: 2 additions & 2 deletions environments/.stackhpc/tofu/cluster_image.auto.tfvars.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cluster_image": {
"RL8": "openhpc-RL8-250130-1126-8f2a7703",
"RL9": "openhpc-RL9-250130-1127-8f2a7703"
"RL8": "openhpc-RL8-250211-1540-a0b4a57e",
"RL9": "openhpc-RL9-250211-1540-a0b4a57e"
}
}
2 changes: 1 addition & 1 deletion environments/.stackhpc/tofu/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ module "cluster" {
standard: { # NB: can't call this default!
nodes: ["compute-0", "compute-1"]
flavor: var.other_node_flavor
compute_init_enable: ["compute", "etc_hosts", "nfs", "basic_users", "eessi"]
compute_init_enable: ["compute", "etc_hosts", "nfs", "basic_users", "eessi", "tuned"]
ignore_image_changes: true
}
# Example of how to add another partition:
Expand Down
Loading