Skip to content

Support mapping compute & login instances to Ironic nodes #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 12, 2025

Adds support for mapping baremetal compute and/or login nodes to ironic hosts with the same names, e.g:

# environments/$env/terraform/terraform.tfvars:
...
cluster_name = "mycloud"
login_nodes = {
    login-0 = {
        flavor: "baremetal.highmem"
        match_ironic_node: true
    }
}
compute = {
    hpc = {
        flavor = "baremetal.xlarge"
        match_ironic_node: true
        availability_zone = "az2"
        nodes = ["hpc-0", "hpc-1", "hpc-2"]
    }
}
...

will result in:

  • An instance named mycloud-login-0 on ironic node login-0 in the default "nova" availability zone
  • Compute instances mycloud-hpc-N on ironic nodes hpc-N in the "az2" availability zone

@sjpb sjpb requested a review from jovial February 12, 2025 14:58
@sjpb sjpb marked this pull request as ready for review February 12, 2025 14:58
@sjpb sjpb requested a review from a team as a code owner February 12, 2025 14:58
@sjpb
Copy link
Collaborator Author

sjpb commented Feb 12, 2025

Tested it works on a cloud without baremetal service, without admin creds.

@sjpb sjpb changed the title Support mapping compute + login instances to Ironic nodes Support mapping compute & login instances to Ironic nodes Feb 12, 2025
Copy link
Collaborator

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sjpb sjpb merged commit f276fb6 into main Feb 13, 2025
2 checks passed
@sjpb sjpb deleted the feat/baremetal_host_v5 branch February 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants