Skip to content

Prevent nfs being mounted by tunnelling/forwarding through login node #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

Prevent nfs being mounted by tunnelling/forwarding through login node #595

merged 3 commits into from
Mar 4, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 28, 2025 •
edited
Loading

  • Disables ssh forwarding and sets secure on nfs exports to prevent mounting shares by tunnelling/forwarding through login node.
  • Also removes /exports/cluster mount from default NFS configuration for safety.

@sjpb sjpb marked this pull request as ready for review February 28, 2025 14:06
@sjpb sjpb requested a review from a team as a code owner February 28, 2025 14:06
jovial
jovial reviewed Feb 28, 2025
View reviewed changes
@sjpb sjpb changed the title Prevent nfs being mounted by tunnelling through login node Prevent nfs being mounted by tunnelling/forwarding through login node Mar 4, 2025
@sjpb sjpb force-pushed the fix/nfs-secure branch from e1a79fc to 7212f2f Compare March 4, 2025 09:09
m-bull
m-bull approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to plug a security gap, but we should probably revisit allowing ssh-agent and x11 forwarding in the future as these are pretty handy!

@sjpb sjpb merged commit 879f627 into main Mar 4, 2025
2 checks passed
@sjpb sjpb deleted the fix/nfs-secure branch March 4, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovial jovial jovial left review comments

@m-bull m-bull m-bull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjpb @jovial @m-bull