Fix: Support networks not owned by openstack project #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGarbutt
reviewed
Mar 3, 2025
environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/nodes.tf
Show resolved
Hide resolved
JohnGarbutt
reviewed
Mar 3, 2025
JohnGarbutt
approved these changes
Mar 3, 2025
sjpb
reviewed
Mar 4, 2025
| port_security_enabled = lookup(each.value, "port_security_enabled", true) | ||
| security_group_ids = lookup(each.value, "port_security_enabled", true) ? var.security_group_ids : [] | ||
| port_security_enabled = lookup(each.value, "port_security_enabled", null) | ||
| security_group_ids = lookup(each.value, "port_security_enabled", null) != false ? var.security_group_ids : [] |
There was a problem hiding this comment.
I don't understand why this wasn't just:
security_group_ids = lookup(each.value, "port_security_enabled", true) ? var.security_group_ids : []
what am I missing here?
There was a problem hiding this comment.
agh you're right I think
There was a problem hiding this comment.
This commit isn't working for me, it still applies the security groups even when port_security_enabled is false. Can you please switch to @sjpb's suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on for #592.
In projects which don't own their networks, port security cannot be manipulated.
Fix sets
port_security_enableddefault tonull. Whennull, security groups are applied.