Skip to content

Fix builds not in stackhpc env #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Mar 11, 2025

Currently builds not using the stackhpc fail because #600 means that cleanup.yml needed the ondemand package version which was only defined for the stackhpc environment.

@sjpb sjpb marked this pull request as ready for review March 11, 2025 15:26
@sjpb sjpb requested a review from a team as a code owner March 11, 2025 15:26
Copy link
Member

@bertiethorpe bertiethorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran into this issue earlier, thanks for fixing it.

@sjpb sjpb force-pushed the fix/non-stackhpc-builds-ondemand branch from c0132a8 to 7817454 Compare March 11, 2025 16:59
@sjpb sjpb merged commit 55be78f into main Mar 11, 2025
2 checks passed
@sjpb sjpb deleted the fix/non-stackhpc-builds-ondemand branch March 11, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants