Skip to content

Compute-init: cope with root-squashed nfs clients #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 19, 2025
Merged

Compute-init: cope with root-squashed nfs clients #627

merged 9 commits into from
Mar 19, 2025

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Mar 14, 2025 •
edited
Loading

Cope with root-squashed nfs from: #599

@bertiethorpe bertiethorpe marked this pull request as ready for review March 14, 2025 16:24
@bertiethorpe bertiethorpe requested a review from a team as a code owner March 14, 2025 16:24
@sjpb sjpb mentioned this pull request Mar 14, 2025
Closed
@bertiethorpe
Copy link
Member Author

bertiethorpe commented Mar 17, 2025 •
edited by sjpb
Loading

new fatimage build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/13903702171
[edit: note this was the bump above]

sjpb
sjpb requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Mostly easy. Can we discuss why we're not injecting the nfs and basic_users roles now though please?

@bertiethorpe bertiethorpe requested a review from sjpb March 18, 2025 18:30
sjpb
sjpb reviewed Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending image bump/CI passes.

@bertiethorpe
Copy link
Member Author

bertiethorpe commented Mar 19, 2025 •
edited
Loading

New fatimage build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/13944611882
[edit: note this was the bump above]

@bertiethorpe bertiethorpe requested a review from sjpb March 19, 2025 13:13
sjpb
sjpb approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on previous review and all CI passing

@bertiethorpe bertiethorpe merged commit fc38aab into main Mar 19, 2025
7 checks passed
@bertiethorpe bertiethorpe deleted the feat/root-squash-compute-init branch March 19, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertiethorpe @sjpb