Skip to content

Document (and test) slurm controlled rebuild configuration and usage #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 8, 2025
Merged

Document (and test) slurm controlled rebuild configuration and usage #634

merged 17 commits into from
Apr 8, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Mar 28, 2025 •
edited
Loading

  • Adds docs (marked experimental) describing how to configure and use the slurm-controlled rebuild feature
  • Configures stackhpc environment and CI to use this approach
  • Adds docs on tweaking deployment parallelism

@sjpb sjpb marked this pull request as ready for review March 28, 2025 15:46
@sjpb sjpb requested a review from a team as a code owner March 28, 2025 15:46
@sjpb sjpb requested review from jovial and bertiethorpe March 28, 2025 15:46
jovial
jovial previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks comprehensive to me. I've not run through the new process, but the steps are described well and I think we can submit any fixes to the process when we come to try it.

bertiethorpe
bertiethorpe previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@bertiethorpe bertiethorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if Will is happy

@sjpb sjpb dismissed stale reviews from bertiethorpe and jovial via d01dc40 April 2, 2025 09:26
@sjpb
Copy link
Collaborator Author

sjpb commented Apr 8, 2025

Image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14328480780

@sjpb sjpb requested a review from bertiethorpe April 8, 2025 13:52
bertiethorpe
bertiethorpe approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@bertiethorpe bertiethorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bertiethorpe bertiethorpe merged commit 9ca2d7f into main Apr 8, 2025
7 checks passed
@bertiethorpe bertiethorpe deleted the docs/rebuild branch April 8, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertiethorpe bertiethorpe bertiethorpe approved these changes

@jovial jovial jovial left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjpb @jovial @bertiethorpe