-
Notifications
You must be signed in to change notification settings - Fork 34
Support fixed IP addresses for nodes #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
Outdated
Show resolved
Hide resolved
b3f0147
to
bf7eb74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this isn't right - logic should be that iff the network key isn't in the map, we default to null, rather than the condition being that the map is empty. So its probably a lookup not a ternary.
The variable control_ip_address was documented but not implemented. Since we support multiple networks, change it to control_ip_addresses and implement it. Closes #642.
427e2c1
to
9b5ed88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested on smslabs. Works. Correct IPs set in metadata on all nodes. site playbook running ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for optional fixed IP addresses via opentofu variable
control_ip_addresses
and parameterip_addresses
for compute and login node groups.Example:
Closes #642.