Skip to content

Change fat image build to create raw image for speed #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 25, 2025
Merged

Change fat image build to create raw image for speed #650

merged 10 commits into from
Apr 25, 2025

Conversation

JohnGarbutt
Copy link
Member

@JohnGarbutt JohnGarbutt commented Apr 11, 2025 •
edited by sjpb
Loading

Skip fatimage image conversion from raw to qcow in cinder volume for speed.

  • Use raw genericcloud image as input for another speedup when using volume-backed fatimage build.
  • Get speedup on doca/lustre/cuda build on same cloud due to raw fatimage.
  • Fatimage upload to s3 converts to qcow. Note download to other clouds does not reconvert to raw at present.

@JohnGarbutt JohnGarbutt requested a review from a team as a code owner April 11, 2025 12:24
@bertiethorpe
Copy link
Member

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14403101501

RL8: 27 mins
RL9: 24 mins

@bertiethorpe bertiethorpe marked this pull request as draft April 14, 2025 13:13
@bertiethorpe bertiethorpe force-pushed the temp/try-raw-images-with-volumes branch from a70d4b6 to 9b9398f Compare April 15, 2025 15:34
JohnGarbutt
JohnGarbutt commented Apr 25, 2025
View reviewed changes
@JohnGarbutt JohnGarbutt changed the title Test if upload as raw from volume is quicker Fat image to create raw image, convert to qcow2 in runner Apr 25, 2025
@JohnGarbutt JohnGarbutt changed the title Fat image to create raw image, convert to qcow2 in runner Fat image to create raw image Apr 25, 2025
@JohnGarbutt JohnGarbutt marked this pull request as ready for review April 25, 2025 15:25
sjpb
sjpb requested changes Apr 25, 2025
View reviewed changes
@JohnGarbutt
Merge remote-tracking branch 'origin/main' into HEAD
9a40bf4 
Conflicts:
environments/.stackhpc/tofu/cluster_image.auto.tfvars.json
@JohnGarbutt
Update rocky 8 to raw
5e3b5d4
sjpb
sjpb requested changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb self-requested a review April 25, 2025 15:37
sjpb
sjpb approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 6b800fd into main Apr 25, 2025
0 of 4 checks passed
@sjpb sjpb deleted the temp/try-raw-images-with-volumes branch April 25, 2025 15:38
@sjpb sjpb changed the title Fat image to create raw image Change fat image build to create raw image for speed Apr 25, 2025
@sjpb sjpb mentioned this pull request May 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnGarbutt @bertiethorpe @sjpb