Skip to content

Fix cuda installs #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

Fix cuda installs #652

merged 3 commits into from
Apr 16, 2025

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Apr 16, 2025

No description provided.

MoteHue added 3 commits April 16, 2025 10:05
The ``rocky`` user's homedir has moved from ``/home/rocky`` to
``/var/lib/rocky``. This updates ``cuda_samples_path`` to use that.
We already hardcode the version of cuda which we install. This ensures
that we will also use the requested version when multiple cuda versions
are installed.

Moves ``cuda_version_short`` to be next to ``cuda_package_version`` so
it's harder to miss updating one when the other is changed.
@MoteHue MoteHue requested a review from a team as a code owner April 16, 2025 09:12
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

No need for new image build.

@sjpb sjpb merged commit d93fe58 into main Apr 16, 2025
4 checks passed
@sjpb sjpb deleted the fix-cuda-installs branch April 16, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants