-
Notifications
You must be signed in to change notification settings - Fork 34
Update grafana to v10 using Ark rpms #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Testing the above build manually failed, repo logic is wrong. Fatimage build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14797550985 |
Tested all dashboards at this commit. All worked, all warned re. angular. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're duplicating the repofile in the Grafana role, we'll need some way of protecting Ark creds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[edit added from Slack chat:] there is still one potential case where creds can get leaked, if you have dnf_repos_password defined but dnf_repos not in groups [then the check in bootstrap doesn't get run]. If you're using creds to do a local build from Ark directly, you could then run site without removing the creds, where dnf_repos wouldn't be in groups since iirc its just set to builder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumps grafana to v10 and uses Ark for stackhpc build, as upstream grafana repos appear to have removed 9.5.21 on or after 2025-04-25. As ark was in on-demand mode the packages are not there either.
Also makes it possible to change whether Packer cleans up resources from failed builds or not on a per-run basis.
Notes: