Skip to content

Make home volume creation optional #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 29, 2025
Merged

Make home volume creation optional #673

merged 9 commits into from
May 29, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented May 16, 2025

  • Adds new OpenTofu variables home_volume_provisioning and state_volume_provisioning to support production cluster configurations. See docs/production.md.
  • Automatically disables the NFS home share when the home volume is disabled (e.g. when home directories are provided via manila).
  • Provides new inventory variable nfs_configurations_extra to make it easier to add site-specific NFS shares.

@sjpb sjpb force-pushed the feat/optional-home-vol-v2 branch from 25f2783 to 40eb623 Compare May 16, 2025 11:16
@sjpb sjpb marked this pull request as ready for review May 16, 2025 16:01
@sjpb sjpb requested a review from a team as a code owner May 16, 2025 16:01
@sjpb sjpb force-pushed the feat/optional-home-vol-v2 branch from d82905c to d810bba Compare May 20, 2025 13:17
@sjpb sjpb force-pushed the feat/optional-home-vol-v2 branch from d810bba to bd891e0 Compare May 20, 2025 13:18
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, docs just need updating

@sjpb sjpb force-pushed the feat/optional-home-vol-v2 branch from 0e48cc8 to ae123b1 Compare May 20, 2025 14:13
@sjpb
Copy link
Collaborator Author

sjpb commented May 20, 2025

Tested state volume is correctly attached both with manage and with attach. Also tested migration route described in production docs for existing clusters.

Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 9541669 into main May 29, 2025
2 checks passed
@sjpb sjpb deleted the feat/optional-home-vol-v2 branch May 29, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants