Skip to content

Allow specifying instance root volume type #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Allow specifying instance root volume type #693

merged 2 commits into from
May 29, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented May 29, 2025

Adds new OpenTofu variable root_volume_type and overrides for compute and login node groups.

Useful on Leafcloud for testing large "extra build" images, where default volume type is encrypted.

@sjpb sjpb marked this pull request as ready for review May 29, 2025 13:11
@sjpb sjpb requested a review from a team as a code owner May 29, 2025 13:11
Copy link
Collaborator

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be set in Leafcloud Packer vars as part of this PR?

@sjpb
Copy link
Collaborator Author

sjpb commented May 29, 2025

Should this be set in Leafcloud Packer vars as part of this PR?

This is for tofu, not packer. It's already set in leafcloud packer vars. Tofu doesn't usually use volume-backed instances, but I ran into this when trying to boot instances on Leafcloud with the cuda image, b/c we don't have flavours with large enough root disks. (With the default encrypted volume type, boot just hangs on "probing EDD".)

@sjpb sjpb requested a review from m-bull May 29, 2025 13:23
@sjpb sjpb changed the title Allow specifying root volume type Allow specifying instance root volume type May 29, 2025
@sjpb sjpb merged commit dfdebdb into main May 29, 2025
2 checks passed
@sjpb sjpb deleted the feat/root-vol-type branch May 29, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants