Allow rockylinux:9 base image #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
commented
Aug 24, 2023
| # Hoepfully they have fixed this issue before this old | ||
| # package is removed. | ||
| # See: https://bugzilla.redhat.com/show_bug.cgi?id=2043753 | ||
| RUN dnf install -y rsync-3.1.3-14.el8 && dnf clean all |
There was a problem hiding this comment.
I haven't tested this change with CS8, but I'm assuming I can move this to the core dnf install. I'm happy to move it back if I'm assuming wrongly though.
markgoddard
reviewed
Aug 29, 2023
This change adds an argument to change the base image when building a kayobe container image, with support for Rocky Linux 9. This is required for the Zed release of Openstack because there is no support for CentOS 8.
Alex-Welsh
force-pushed
the
variable-image
branch
from
9febe1b to
7e2807e
Compare
markgoddard
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an argument to change the base image when building a kayobe container image, with support for rocky linux 9. This is required for the Zed release of Openstack because there is no support for CentOS 8.
Ideally it'd be a bit more flexible with the exact image used but this is already a bit of a yak-shave away from what I should be doing at the moment anyway.