Skip to content

Commit 726e2fd

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "[FUP] this change removes an unused paramater"
2 parents bc19a33 + 936039d commit 726e2fd

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

nova/compute/manager.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8105,7 +8105,7 @@ def _neutron_failed_migration_callback(event_name, instance):
81058105
LOG.error(msg, msg_args)
81068106

81078107
@staticmethod
8108-
def _get_neutron_events_for_live_migration(instance, migration):
8108+
def _get_neutron_events_for_live_migration(instance):
81098109
# We don't generate events if CONF.vif_plugging_timeout=0
81108110
# meaning that the operator disabled using them.
81118111
if CONF.vif_plugging_timeout:
@@ -8181,8 +8181,7 @@ class _BreakWaitForInstanceEvent(Exception):
81818181
"""
81828182
pass
81838183

8184-
events = self._get_neutron_events_for_live_migration(
8185-
instance, migration)
8184+
events = self._get_neutron_events_for_live_migration(instance)
81868185
try:
81878186
if ('block_migration' in migrate_data and
81888187
migrate_data.block_migration):

nova/tests/unit/compute/test_compute_mgr.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9280,7 +9280,7 @@ def test_get_neutron_events_for_live_migration_empty(self):
92809280
self.assertTrue(nw_info.return_value[0].is_hybrid_plug_enabled())
92819281
self.assertEqual(
92829282
[], self.compute._get_neutron_events_for_live_migration(
9283-
self.instance, migration))
9283+
self.instance))
92849284

92859285
# 2. no VIFs
92869286
self.flags(vif_plugging_timeout=300)
@@ -9289,7 +9289,7 @@ def test_get_neutron_events_for_live_migration_empty(self):
92899289
nw_info.return_value = network_model.NetworkInfo([])
92909290
self.assertEqual(
92919291
[], self.compute._get_neutron_events_for_live_migration(
9292-
self.instance, migration))
9292+
self.instance))
92939293

92949294
# 3. no plug time events
92959295
with mock.patch.object(self.instance, 'get_network_info') as nw_info:
@@ -9300,7 +9300,7 @@ def test_get_neutron_events_for_live_migration_empty(self):
93009300
self.assertFalse(nw_info.return_value[0].is_hybrid_plug_enabled())
93019301
self.assertEqual(
93029302
[], self.compute._get_neutron_events_for_live_migration(
9303-
self.instance, migration))
9303+
self.instance))
93049304

93059305
@mock.patch('nova.compute.rpcapi.ComputeAPI.pre_live_migration')
93069306
@mock.patch('nova.compute.manager.ComputeManager._post_live_migration')

0 commit comments

Comments
 (0)