Skip to content

INFRA-629: Update dashboards to use non-deprecated plugin #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 13, 2024
Merged

INFRA-629: Update dashboards to use non-deprecated plugin #1018

merged 13 commits into from
May 13, 2024

Conversation

dougszumski
Copy link
Member

@dougszumski dougszumski commented Apr 5, 2024 •
edited
Loading

No functional change where possible.

  1. Update plugins to fix deprecation notices
  2. Remove panels wheres metrics no longer available ( OpenSearch)
  3. Check in latest Grafana definition of the dashboard to reduce future diffs

Drink a strong coffee before even considering looking at the json diffs.

@dougszumski
INFRA-629: Update cAdvisor dashboard
bc62dfd 
No functional change - update to fix deprecation notices
@dougszumski dougszumski requested a review from a team as a code owner April 5, 2024 15:37
@dougszumski dougszumski marked this pull request as draft April 5, 2024 15:37
@dougszumski
INFRA-629: Update database dashboard
31b13a2
@dougszumski
INFRA-629: Update OpenSearch dashboard
9367f36 
This converts old panels, and removes panels where there are no
longer metrics available (since we are still using the ES exporter).

This dashboard can be revised separately with an OpenSearch specific
metrics source.

Currently it is too complicated - we should simplify it.
@dougszumski dougszumski changed the title INFRA-629: Update cAdvisor dashboard INFRA-629: Update dashboards to use non-deprecated plugin Apr 5, 2024
@Alex-Welsh
Copy link
Member

Is this the sort of thing that should go into yoga and get merged up?

@dougszumski
Copy link
Member Author

Is this the sort of thing that should go into yoga and get merged up?

A good question and it's a bit of grey area to me.

Personally I don't think we should do a major upgrade of Grafana/anything in Yoga, in which case, we don't need these to be backported. Grafana should remain on 10.x in Yoga.

However, Grafana is unpinned in Kolla, so if someone rebuilds the Grafana (Yoga) image in release train, it will get upgraded to 11.x in May 2024? Then we would want to have this PR targeted to Yoga. Ideally I think we should avoid that, unless there is a good reason not to.

@Alex-Welsh
Copy link
Member

Is this the sort of thing that should go into yoga and get merged up?

A good question and it's a bit of grey area to me.

Personally I don't think we should do a major upgrade of Grafana/anything in Yoga, in which case, we don't need these to be backported. Grafana should remain on 10.x in Yoga.

However, Grafana is unpinned in Kolla, so if someone rebuilds the Grafana (Yoga) image in release train, it will get upgraded to 11.x in May 2024? Then we would want to have this PR targeted to Yoga. Ideally I think we should avoid that, unless there is a good reason not to.

I think we'll have to assume that we'll have to rebuild the yoga images at some point due to a security backport. What we do to prepare for that I'm not exactly sure

@markgoddard
Copy link
Contributor

I'd probably rather that we pin grafana version to 10.x in yoga than replace all the dashboards.

@technowhizz
Copy link
Contributor

One thing to add is we should also aim in this re-do to have all the time frames the same (ie the time window in grafana when looking at a graph.) I think the past 24 hours for all is reasonable? @dougszumski @assumptionsandg

@assumptionsandg assumptionsandg force-pushed the conf/INFRA-629 branch 2 times, most recently from 1ad9119 to 42307df Compare April 24, 2024 16:04
@dougszumski dougszumski marked this pull request as ready for review May 13, 2024 09:42
dougszumski
dougszumski commented May 13, 2024
View reviewed changes
Copy link
Member Author

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've loaded these in to an aio running Grafana 10.4.2 and what we have so far looks fine.

@technowhizz
Update Ceph MDS Dashboard
e09beae 
Change-Id: I86dab29368219ea60856d95972cfa103ddbbc75b
@technowhizz
Update OSD dashboard
449c0ae 
Change-Id: I967679593803d36f813c942bb2af627621214b7d
@technowhizz
Update ceph overview dashboard
fd00ced 
Change-Id: Iaeffe49f43e0deb436ee61a238e5025a3aac349b
@technowhizz
Update Ceph Pools Dashboard
e27cf91 
Change-Id: I9d0060f2d488300159b2e77f4f4f876db7bac3e6
@dougszumski
Copy link
Member Author

I see the AngularJS warnings fixed in the above Ceph commits

@dougszumski
Copy link
Member Author

Let's merge this and follow up with the remaining dashboards

@dougszumski dougszumski merged commit 9c07a7c into stackhpc/2023.1 May 13, 2024
12 checks passed
@dougszumski dougszumski deleted the conf/INFRA-629 branch May 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dougszumski @Alex-Welsh @markgoddard @technowhizz @assumptionsandg