Add generic blackbox monitoring configuration #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
force-pushed
the
generic-blackbox
branch
2 times, most recently
from
eba14f9 to
d9187c4
Compare
priteau
reviewed
Apr 15, 2024
Alex-Welsh
force-pushed
the
generic-blackbox
branch
from
d9187c4 to
facde12
Compare
markgoddard
reviewed
Apr 15, 2024
Alex-Welsh
force-pushed
the
generic-blackbox
branch
from
facde12 to
c7677ab
Compare
Alex-Welsh
force-pushed
the
generic-blackbox
branch
2 times, most recently
from
a3432dc to
e7b4a9e
Compare
|
Marked as draft as recent changes are untested |
Alex-Welsh
force-pushed
the
generic-blackbox
branch
3 times, most recently
from
b244f26 to
1150cc7
Compare
Alex-Welsh
commented
May 1, 2024
Alex-Welsh
force-pushed
the
generic-blackbox
branch
3 times, most recently
from
16dc469 to
562affb
Compare
Alex-Welsh
force-pushed
the
generic-blackbox
branch
from
562affb to
12815dd
Compare
dougszumski
reviewed
May 31, 2024
There was a problem hiding this comment.
I'm not opposed to merging this as-is, but it would be good to investigate the file based service discovery approach I mentioned upstream. We should be able to do something similar downstream, but using Kayobe to write out the service discovery file(s) instead of the KA roles.
|
is it ready to merge? it would be good to define blackbox exporter defaults |
From the monitoring R&D discussion, we're going to proceed with this style downstream, and investigate file based discovery upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.