OS Capacity: Support providing a CA certificate #1079
Merged
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adapted from #896 |
There was a problem hiding this comment.
Has this been tested?
When testing #896 on SMS lab the container would always crash on SSL validation even when the cacert was provided and mounted in the container.
That could’ve just been me messing it up though.
I've tested it in a multinode, and it fixed the container's restart loop. |
For clouds that use an internal CA, it is necessary to provide a CA certificate to OS capacity. Co-Authored-By: Jake Hutchinson <[email protected]>
markgoddard
force-pushed
the
os-capacity-cacert
branch
from
29cd0b1 to
a0331ca
Compare
assumptionsandg
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clouds that use an internal CA, it is necessary to provide a CA certificate to OS capacity.