Skip to content

Yoga Infiniband #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Yoga Infiniband #1102

wants to merge 11 commits into from

Conversation

tomclark0
Copy link
Contributor

Bringing up networking-mlnx in yoga to support Infiniband based networking via neutron with nova support.

Yoga is used as this is the release available in the environment for testing and validation.
There are currently no builds of networking-mlnx since the zed release cycle.

This patch enables building of the neutron-mlnx-agent container.
This container also provides the neutron-eswitchd container.
The networking-mlnx package is required in neutron_server and added as a plugin.
The networking-mlnx package is required in nova-compute and added as a plugin.

The networking-mlnx plugin has additional dependencies on system-level packages python3-libvirt python3-ethtool.
These are added to neutron_server and nova_compute.

networking-mlnx is required in nova-compute as it provides the ebrctl binary used for managing Infiniband VIFs - e.g. https://github.com/openstack/nova/blob/unmaintained/yoga/nova/privsep/libvirt.py#L115-L118

@tomclark0
Copy link
Contributor Author

Working here in favour of #1093 as the current environment available for Infiniband is Yoga based.

@tomclark0 tomclark0 marked this pull request as ready for review June 18, 2024 11:52
@tomclark0 tomclark0 requested a review from a team as a code owner June 18, 2024 11:52
@tomclark0 tomclark0 marked this pull request as draft June 18, 2024 11:54
@tomclark0 tomclark0 marked this pull request as ready for review June 24, 2024 12:18
@tomclark0 tomclark0 marked this pull request as draft July 29, 2024 12:16
@tomclark0 tomclark0 marked this pull request as ready for review July 29, 2024 13:19
neutron_server_packages_append:
- python3-libvirt
- python3-ethtool
nova_compute_packages_append:
Copy link
Contributor

@jovial jovial Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly, this gets overridden by: nova_compute_packages_append:

Due to https://github.com/stackhpc/stackhpc-kayobe-config/pull/1102/files#diff-12d955d16a7bd8d6dc7bae8b56c2e485f4445434f0fb67546ea09c9e8b9b504dR516

I think we need to append them to:

  nova_compute_packages_remove:
    - openvswitch

in kolla_build_customizations_el as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing we need is a release note

@Alex-Welsh
Copy link
Member

@tomclark0 What's the status of this PR? we'll be dropping support for Yoga fairly soon so it'd be good to get this finished off

@Alex-Welsh
Copy link
Member

@tomclark0 should we close this PR?

@tomclark0 tomclark0 closed this Nov 12, 2024
@tomclark0 tomclark0 deleted the yoga-infiniband branch November 14, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants