Skip to content

Stop changing permissions on files #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Jun 27, 2024

These are causing changes to docker overlay filesystems with possible unintended consequences. It is also really slow to loop through so many files in ansible.

@jovial jovial requested a review from a team as a code owner June 27, 2024 15:39
@jovial jovial marked this pull request as draft June 27, 2024 15:47
These are causing changes to docker overlay filesystems with
possible unintended consequences. It is also really slow to loop
through so many files in ansible.
@jovial jovial force-pushed the bugfix/cis-perms branch from bbe151b to 16769f3 Compare June 27, 2024 15:53
@jovial jovial marked this pull request as ready for review July 8, 2024 16:37
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to do the same for RHEL?

Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these group_vars be moved to the cis-hardening group?

@jovial
Copy link
Contributor Author

jovial commented Jul 12, 2024

Should these group_vars be moved to the cis-hardening group?

Will do that in #1104

@jovial
Copy link
Contributor Author

jovial commented Jul 12, 2024

Do we not need to do the same for RHEL?

I believe I checked and couldn't see it doing the same kind of permission changes

@jovial jovial merged commit 0d1dfe2 into stackhpc/2023.1 Jul 12, 2024
12 checks passed
@jovial jovial deleted the bugfix/cis-perms branch July 12, 2024 17:58
markgoddard added a commit that referenced this pull request Jul 22, 2024
A similar change was made for Ubuntu systems in #1119, but it did not
apply to Rocky 9 systems. This changes brings the two into line.
markgoddard added a commit that referenced this pull request Jul 23, 2024
A similar change was made for Ubuntu systems in #1119, but it did not
apply to Rocky 9 systems. This changes brings the two into line.

(cherry picked from commit ef96aa2)
markgoddard pushed a commit that referenced this pull request Jul 23, 2024
These are causing changes to docker overlay filesystems with
possible unintended consequences. It is also really slow to loop
through so many files in ansible.

(cherry picked from commit 0d1dfe2)
This was referenced Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants