-
Notifications
You must be signed in to change notification settings - Fork 23
Removing angular based dashboards #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is last dashboard from this task: https://stackhpc.atlassian.net/browse/INFRA-629. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main issue is a templating issue which prevents deployment:
TASK [grafana : Copying over extra configuration file] ****************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'env' is undefined. 'env' is undefined
failed: [doug-aio] (item={'path': '/home/ubuntu/src/kayobe-config/etc/kolla/config/grafana/redfish.json', 'mode': '0640', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 1000, 'gid': 1003, 'size': 92743, 'inode': 527227, 'dev': 64513, 'nlink': 1, 'atime': 1720609092.533431, 'mtime': 1720609092.1894255, 'ctime': 1720609092.533431, 'gr_name': 'kolla', 'pw_name': 'ubuntu', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': False, 'xoth': False, 'isuid': False, 'isgid': False}) => {"ansible_loop_var": "item", "changed": false, "item": {"atime": 1720609092.533431, "ctime": 1720609092.533431, "dev": 64513, "gid": 1003, "gr_name": "kolla", "inode": 527227, "isblk": false, "ischr": false, "isdir": false, "isfifo": false, "isgid": false, "islnk": false, "isreg": true, "issock": false, "isuid": false, "mode": "0640", "mtime": 1720609092.1894255, "nlink": 1, "path": "/home/ubuntu/src/kayobe-config/etc/kolla/config/grafana/redfish.json", "pw_name": "ubuntu", "rgrp": true, "roth": false, "rusr": true, "size": 92743, "uid": 1000, "wgrp": false, "woth": false, "wusr": true, "xgrp": false, "xoth": false, "xusr": false}, "msg": "AnsibleUndefinedVariable: 'env' is undefined. 'env' is undefined"}`
Please can you check it deploys ok and update the PR?
etc/kayobe/kolla/config/grafana/dashboards/openstack/redfish.json
Outdated
Show resolved
Hide resolved
etc/kayobe/kolla/config/grafana/dashboards/openstack/redfish.json
Outdated
Show resolved
Hide resolved
etc/kayobe/kolla/config/grafana/dashboards/openstack/redfish.json
Outdated
Show resolved
Hide resolved
@dougszumski I can't reproduce problem with deployment and missing "env" variable. I have deployed it in ci-aio env without problems. Can check again? |
Thanks, my bad. I had a copy lurking in the config/grafana folder which triggered the templating attempt |
I currently don't have an environment to test this in outside of an aio. It looks fine in the aio, and I don't see any warnings about Angular but obviously I don't have any data. We can follow up with any fixes if required - it's a good step forward, thanks @GregWhiteyBialas . |
2498700
to
e4e119f
Compare
etc/kayobe/kolla/config/grafana/dashboards/openstack/redfish.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GregWhiteyBialas , all warnings resolved. I don't have access to a test env currently, but will try on sms in the near future.
Please squash the commits before merging
Argh, auto-merge caught me out. Not to worry. |
No description provided.