Skip to content

Removing angular based dashboards #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Removing angular based dashboards #1138

merged 3 commits into from
Jul 22, 2024

Conversation

GregWhiteyBialas
Copy link
Contributor

No description provided.

@GregWhiteyBialas GregWhiteyBialas requested a review from a team as a code owner July 8, 2024 14:52
@GregWhiteyBialas
Copy link
Contributor Author

This is last dashboard from this task: https://stackhpc.atlassian.net/browse/INFRA-629.

Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue is a templating issue which prevents deployment:

TASK [grafana : Copying over extra configuration file] ****************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'env' is undefined. 'env' is undefined
failed: [doug-aio] (item={'path': '/home/ubuntu/src/kayobe-config/etc/kolla/config/grafana/redfish.json', 'mode': '0640', 'isdir': False, 'ischr': False, 'isblk': False, 'isreg': True, 'isfifo': False, 'islnk': False, 'issock': False, 'uid': 1000, 'gid': 1003, 'size': 92743, 'inode': 527227, 'dev': 64513, 'nlink': 1, 'atime': 1720609092.533431, 'mtime': 1720609092.1894255, 'ctime': 1720609092.533431, 'gr_name': 'kolla', 'pw_name': 'ubuntu', 'wusr': True, 'rusr': True, 'xusr': False, 'wgrp': False, 'rgrp': True, 'xgrp': False, 'woth': False, 'roth': False, 'xoth': False, 'isuid': False, 'isgid': False}) => {"ansible_loop_var": "item", "changed": false, "item": {"atime": 1720609092.533431, "ctime": 1720609092.533431, "dev": 64513, "gid": 1003, "gr_name": "kolla", "inode": 527227, "isblk": false, "ischr": false, "isdir": false, "isfifo": false, "isgid": false, "islnk": false, "isreg": true, "issock": false, "isuid": false, "mode": "0640", "mtime": 1720609092.1894255, "nlink": 1, "path": "/home/ubuntu/src/kayobe-config/etc/kolla/config/grafana/redfish.json", "pw_name": "ubuntu", "rgrp": true, "roth": false, "rusr": true, "size": 92743, "uid": 1000, "wgrp": false, "woth": false, "wusr": true, "xgrp": false, "xoth": false, "xusr": false}, "msg": "AnsibleUndefinedVariable: 'env' is undefined. 'env' is undefined"}`

Please can you check it deploys ok and update the PR?

@GregWhiteyBialas
Copy link
Contributor Author

@dougszumski I can't reproduce problem with deployment and missing "env" variable. I have deployed it in ci-aio env without problems. Can check again?

@dougszumski
Copy link
Member

@dougszumski I can't reproduce problem with deployment and missing "env" variable. I have deployed it in ci-aio env without problems. Can check again?

Thanks, my bad. I had a copy lurking in the config/grafana folder which triggered the templating attempt

@dougszumski
Copy link
Member

I currently don't have an environment to test this in outside of an aio. It looks fine in the aio, and I don't see any warnings about Angular but obviously I don't have any data. We can follow up with any fixes if required - it's a good step forward, thanks @GregWhiteyBialas .

dougszumski
dougszumski previously approved these changes Jul 12, 2024
@dougszumski dougszumski enabled auto-merge July 12, 2024 11:10
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GregWhiteyBialas , all warnings resolved. I don't have access to a test env currently, but will try on sms in the near future.

Please squash the commits before merging

@dougszumski dougszumski merged commit 97cc295 into stackhpc/2023.1 Jul 22, 2024
12 checks passed
@dougszumski dougszumski deleted the INFRA-629 branch July 22, 2024 10:43
@dougszumski
Copy link
Member

Thanks @GregWhiteyBialas , all warnings resolved. I don't have access to a test env currently, but will try on sms in the near future.

Please squash the commits before merging

Argh, auto-merge caught me out. Not to worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants