-
Notifications
You must be signed in to change notification settings - Fork 23
Encrypt wazuh-secrets.yml once templated #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0b0860
to
0276fc9
Compare
b23ba38
to
65029a2
Compare
4cea2d7
to
0d10560
Compare
@MaxBed4d you don't need to make PRs for your own branches 🙂 |
The changes here were to achieve a different goal from the other branch, however this branch relies and builds on the changes from the other branch. The two branches felt like two separate PRs, but this could not be merged into |
In the future, one PR for "Wazuh deployment script improvements" with two commits would be fine. I also don't really see how this one relies on the other, they wouldn't conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaxBed4d - this works fine.
debug: | ||
msg: >- | ||
Please encrypt the keys using Ansible Vault. | ||
- name: In-place encrypt wazuh-secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside of this no longer being a handler is that it will reencrypt the content each time you run the playbook, even if there are no plain text changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would something like this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, or going back to a handler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxBed4d please could you also update the doc for the modified process: https://github.com/stackhpc/stackhpc-kayobe-config/blob/Wazuh-Docs-TLS/doc/source/configuration/wazuh.rst#the-short-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougszumski Of course! On it!
They're encrypted automatically now: #1171
No description provided.