Skip to content

Allow reboot playbook to run with bootstrap user #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

Allow reboot playbook to run with bootstrap user #1221

merged 1 commit into from
Aug 16, 2024

Conversation

Alex-Welsh
Copy link
Member

Added a reboot_with_bootstrap_user variable to the reboot playbook so it can be run on hosts that haven't been configured with kayobe.

Required to unblock Caracal CI AIO upgrade jobs

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner August 12, 2024 12:25
MaxBed4d
MaxBed4d previously approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@MaxBed4d MaxBed4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question is that shouldn't reboot_with_bootstrap_user be able to be set outside of reboot.yml such that scripts, like the Ubuntu upgrade ones, can set this as and when appropriate?

@Alex-Welsh
Copy link
Member Author

LGTM, only question is that shouldn't reboot_with_bootstrap_user be able to be set outside of reboot.yml such that scripts, like the Ubuntu upgrade ones, can set this as and when appropriate?

Yeah, playbook vars can be overridden just like this: e346c89#diff-1102ab2bf041f53bc9ea3960af85f9852b3a4632c2e2d8bfa3bec097dc7090f8R273
It's a pattern we use somewhat regularly

@Alex-Welsh Alex-Welsh mentioned this pull request Aug 12, 2024
Merged
markgoddard
markgoddard suggested changes Aug 14, 2024
View reviewed changes
MaxBed4d
MaxBed4d approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@MaxBed4d MaxBed4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markgoddard markgoddard merged commit d76ba77 into stackhpc/2023.1 Aug 16, 2024
12 checks passed
@markgoddard markgoddard deleted the reboot branch August 16, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

@MaxBed4d MaxBed4d MaxBed4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-Welsh @markgoddard @MaxBed4d