-
Notifications
You must be signed in to change notification settings - Fork 23
Add RabbitMQ Quorum queue migration playbook #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f3f04c
to
be31d10
Compare
6a0af50
to
4e5e88d
Compare
Tested & working |
65200d4
to
ad8aa2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall I'd prefer to see this structured as 2 playbooks - prechecks and postchecks, and a script. If it's going to be explicitly marked as only for CI then I'd accept it in its current form.
I'll restructure it |
cc8ebe9
to
1a1a385
Compare
@markgoddard unfortunate timing on that review I'm afraid. I've just refactored it all into a script. It would've had to be at least 3 playbooks to cover all the checks I think, so I moved them all into the script and just use I was pushing to this branch just to make it easier to pull the changes to my AIOs for testing |
General thoughts on the new script approach would be welcome though |
420b32f
to
f05edfb
Compare
f05edfb
to
eedc6fa
Compare
Again, tested and working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Docs will need an update, but could be done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested myself, but looks good from my eyes
This playbook is required for the upgrade job in Caracal CI
Tested & working