Skip to content

Add RabbitMQ Quorum queue migration playbook #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

Alex-Welsh
Copy link
Member

@Alex-Welsh Alex-Welsh commented Aug 13, 2024

This playbook is required for the upgrade job in Caracal CI

Tested & working

@Alex-Welsh Alex-Welsh marked this pull request as ready for review August 15, 2024 14:31
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner August 15, 2024 14:31
@Alex-Welsh
Copy link
Member Author

Tested & working

Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall I'd prefer to see this structured as 2 playbooks - prechecks and postchecks, and a script. If it's going to be explicitly marked as only for CI then I'd accept it in its current form.

@Alex-Welsh
Copy link
Member Author

I think overall I'd prefer to see this structured as 2 playbooks - prechecks and postchecks, and a script. If it's going to be explicitly marked as only for CI then I'd accept it in its current form.

I'll restructure it

@Alex-Welsh Alex-Welsh marked this pull request as draft August 16, 2024 10:14
@Alex-Welsh Alex-Welsh force-pushed the rabbit-upgrade branch 2 times, most recently from cc8ebe9 to 1a1a385 Compare August 16, 2024 13:33
@Alex-Welsh
Copy link
Member Author

@markgoddard unfortunate timing on that review I'm afraid. I've just refactored it all into a script. It would've had to be at least 3 playbooks to cover all the checks I think, so I moved them all into the script and just use host command run to check controllers.

I was pushing to this branch just to make it easier to pull the changes to my AIOs for testing

@Alex-Welsh
Copy link
Member Author

General thoughts on the new script approach would be welcome though

@Alex-Welsh Alex-Welsh force-pushed the rabbit-upgrade branch 5 times, most recently from 420b32f to f05edfb Compare August 19, 2024 13:07
@Alex-Welsh Alex-Welsh marked this pull request as ready for review August 19, 2024 15:45
@Alex-Welsh
Copy link
Member Author

Again, tested and working

Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Docs will need an update, but could be done in a separate PR.

MoteHue
MoteHue previously approved these changes Aug 20, 2024
Copy link
Contributor

@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested myself, but looks good from my eyes

@Alex-Welsh Alex-Welsh enabled auto-merge August 20, 2024 09:47
@Alex-Welsh Alex-Welsh merged commit 6281412 into stackhpc/2023.1 Aug 20, 2024
12 checks passed
@Alex-Welsh Alex-Welsh deleted the rabbit-upgrade branch August 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants