Skip to content

2023.1: zed merge #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 6, 2024
Merged

2023.1: zed merge #1265

merged 8 commits into from
Sep 6, 2024

Conversation

markgoddard
Copy link
Contributor

  • ci-multinode: Add Kolla Ansible TLS config to globals.yml
  • Add workaround for rc: -13 (Add workaround for rc: -13 #1108)
  • Disable yamllint in ci-multinode globals.yml

markgoddard and others added 8 commits August 22, 2024 12:27
Previously we provided an additional file, globals-tls-config.yml, which
would be appended to globals.yml at an appropriate point during
multinode deployment. This could result in a merge conflict, which
cannot be resolved by an automated process such as a GitHub Actions
workflow.

This change adds the TLS config to globals.yml conditionally, based on
whether internal TLS is enabled.

We are not removing globals-tls-config.yml for now, since it is used in
the terraform-kayobe-multinode repo as a proxy for internal TLS support.
The file has already been removed in the Antelope branch.
I've commonly hit this when configuring prometheus:

```
TASK [prometheus : Get container facts] *************************************************************************************************************************************
Monday 24 June 2024  11:09:37 +0000 (0:00:08.528)       0:01:31.707 ***********
fatal: [will-compute-01]: FAILED! => changed=false
  module_stderr: ''
  module_stdout: ''
  msg: |-
    MODULE FAILURE
    See stdout/stderr for the exact error
  rc: -13
fatal: [will-compute-02]: FAILED! => changed=false
  module_stderr: ''
  module_stdout: ''
  msg: |-
    MODULE FAILURE
    See stdout/stderr for the exact error
  rc: -13
```

The ControlPersist  workaround is documented in these bug reports:

- ansible/ansible#78344
- ansible/ansible#81777

From the comments, It seems like this does not completely resolve the
issue, but does decrease the frequency that you hit this.

The Prometheus tasks seem particuarly susceptible as they run on
every host.

(cherry picked from commit 699769c)
yoga: Backport Add workaround for rc: -13 (#1108)
zed: ci-multinode: Add Kolla Ansible TLS config to globals.yml
@markgoddard markgoddard requested a review from a team as a code owner September 6, 2024 11:38
@markgoddard markgoddard self-assigned this Sep 6, 2024
@markgoddard markgoddard merged commit 96eb985 into stackhpc/2023.1 Sep 6, 2024
12 checks passed
@markgoddard markgoddard deleted the 2023.1-zed-merge branch September 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants