-
Notifications
You must be signed in to change notification settings - Fork 23
Caracal host images #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Caracal host images #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches our current defaults.
the etc-hosts DIB element was previously used to inject config for the old sms pulp, which is no longer used
Ubuntu host image builds currently fail due to an issue with debootstrap. This change switches the builder to an Ubuntu VM.
84ec0f0
to
e0ee3a5
Compare
seunghun1ee
previously approved these changes
Sep 13, 2024
markgoddard
previously approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it passes.
I'm reasonably sure that the RL9 upgrade job will fail due to the selinux change, I'll convert to draft for now |
The RL9 AIO upgrade job has been failing because the Antelope image is built with selinux disabled rather than permissive. At the moment, AIOs cannot be rebooted without losing connection, so the best option is to continue setting selinux_state=disabled after upgrading to Caracal
1872e36
seunghun1ee
approved these changes
Sep 16, 2024
MoteHue
approved these changes
Sep 16, 2024
markgoddard
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woop, selinux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.