Skip to content

Fix upgrade-prerequisites #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fix upgrade-prerequisites #1335

merged 3 commits into from
Nov 13, 2024

Conversation

Alex-Welsh
Copy link
Member

The KAYOBE_CONFIG_ROOT variable is out of scope so is undefined:
/home/ubuntu/src/kayobe-config/tools/upgrade-prerequisites.sh: line 38: /tools/rabbitmq-quorum-migration.sh: No such file or directory

Even though the script is being called using that very same variable: https://github.com/stackhpc/terraform-kayobe-multinode/blob/main/ansible/files/multinode.sh#L374

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner October 16, 2024 15:01
@Alex-Welsh Alex-Welsh marked this pull request as draft October 16, 2024 15:06
@Alex-Welsh
Copy link
Member Author

Converted to draft - untested

@seunghun1ee
Copy link
Member

I had to make this change on customer system upgrade. So, this is tested. However we didn't considered the case when the system doesn't use Kayobe environment. I'll add a commit for this.

@Alex-Welsh
Copy link
Member Author

I had to make this change on customer system upgrade. So, this is tested. However we didn't considered the case when the system doesn't use Kayobe environment. I'll add a commit for this.

We discussed this in person but for future reference, this script is designed to be run in CI only. There are too many edge cases on customer deployments to cover

@Alex-Welsh Alex-Welsh marked this pull request as ready for review November 4, 2024 16:28
@Alex-Welsh
Copy link
Member Author

Alex-Welsh commented Nov 4, 2024

Tested and working here: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/11662590141/job/32469246299

There's a weird order of operations here:
This PR needs to merge
Then this one in the github workflows: stackhpc/stackhpc-openstack-gh-workflows#8
Then I need to make a new release of that repo
Then I need to make a new PR to SKC stackhpc/2024.1 which will bump the version it uses to that release

I've been testing this change with some experimental branches:
stackhpc/2024.1...caracal-multinode
stackhpc/stackhpc-openstack-gh-workflows@main...alex-test-branch

@Alex-Welsh Alex-Welsh merged commit 548a236 into stackhpc/2023.1 Nov 13, 2024
12 checks passed
@Alex-Welsh Alex-Welsh deleted the upgrade-prerequisites branch November 13, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants