fix: test if admin-openrc.sh exists before deploying os-capacity
#1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assumptionsandg
previously approved these changes
Oct 28, 2024
jackhodgkiss
force-pushed
the
2023.1-os-capacity-no-admin
branch
from
90e2631 to
5f54d97
Compare
jackhodgkiss
force-pushed
the
2023.1-os-capacity-no-admin
branch
from
5f54d97 to
2a7e720
Compare
assumptionsandg
previously approved these changes
Oct 29, 2024
Alex-Welsh
reviewed
Nov 4, 2024
During service deploys using Kayobe Automation this playbook will fail as the `admin-openrc.sh` file is not generated during the deployment process. This in turn causes the workflow to be reported as a failure even though the service deployment succeeded.
jackhodgkiss
force-pushed
the
2023.1-os-capacity-no-admin
branch
from
2a7e720 to
77dce90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During service deploys using Kayobe Automation this playbook will fail as the
admin-openrc.shfile is not generated during the deployment process.This in turn causes the workflow to be reported as a failure even though the service deployment succeeded.