Skip to content

fix!: manage the physical interface in ci-aio #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jackhodgkiss
Copy link
Contributor

Treat the physical interface as network interface inside of the ci-aio environment. This is to ensure the network interface files are created correctly with the appropriate permissions otherwise we will lose connection after the DHCP lease expires. Also this approach enables us to include the interface within the firewall configuration ensuring we maintain SSH access through the firewall via this interface.

@jackhodgkiss jackhodgkiss added the bug Something isn't working label Nov 4, 2024
@jackhodgkiss jackhodgkiss self-assigned this Nov 4, 2024
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner November 4, 2024 22:51
@jovial
Copy link
Contributor

jovial commented Nov 5, 2024

Guess the conflict comes from:

- name: Write Terraform network interface config
run: |
cat << EOF > etc/kayobe/environments/$KAYOBE_ENVIRONMENT/inventory/group_vars/controllers/tf-network-interfaces
admin_interface: "{{ access_interface.value }}"
EOF

@jackhodgkiss jackhodgkiss force-pushed the fix-ci-aio-networking branch 3 times, most recently from cd64f8f to a4029b4 Compare November 5, 2024 11:25
@jackhodgkiss jackhodgkiss changed the base branch from stackhpc/2024.1 to stackhpc/yoga November 5, 2024 13:01
@jackhodgkiss jackhodgkiss force-pushed the fix-ci-aio-networking branch 2 times, most recently from 06704f2 to abf6f9c Compare November 5, 2024 13:31
Treat the physical interface as network interface inside of the `ci-aio` environment. This
is to ensure the network interface files are created correctly with the appropriate permissions
otherwise we will lose connection after the DHCP lease expires. Also this approach enables us
to include the interface within the firewall configuration ensuring we maintain SSH access through
the firewall via this interface.
@jackhodgkiss jackhodgkiss force-pushed the fix-ci-aio-networking branch from abf6f9c to d229d41 Compare November 5, 2024 14:07
@Alex-Welsh
Copy link
Member

I like the approach but one comment, can we keep the original admin name, or maybe switch to admin_oc? It's a bit clearer than ethernet imo

@jackhodgkiss
Copy link
Contributor Author

I like the approach but one comment, can we keep the original admin name, or maybe switch to admin_oc? It's a bit clearer than ethernet imo

I prefer ethernet because it the port plugged into the VM or instance. It is only called admin_oc here because of how AIO within the context of CI is configured.

@jackhodgkiss jackhodgkiss merged commit 9942b12 into stackhpc/yoga Nov 5, 2024
15 checks passed
@jackhodgkiss jackhodgkiss deleted the fix-ci-aio-networking branch November 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants