Skip to content

Fix growroot LVM check #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix growroot LVM check #1460

merged 1 commit into from
Jan 16, 2025

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Jan 15, 2025 •
edited
Loading

grep -q always returns rc 141 [1], so the check will never pass. Send the output to /dev/null so we capture the correct return code from grep.

[1] https://stackoverflow.com/questions/19120263/why-exit-code-141-with-grep-q

@MoteHue MoteHue requested a review from a team as a code owner January 15, 2025 12:56
@product-auto-label product-auto-label bot added size: xs ansible Ansible playbooks labels Jan 15, 2025
@MoteHue MoteHue mentioned this pull request Jan 15, 2025
Open
@MoteHue
Fix growroot LVM check
a4965df 
``grep -q`` always returns rc 141 [1], so the check will never pass.
Send the output to /dev/null so we capture the correct return code
from grep.

[1] https://stackoverflow.com/questions/19120263/why-exit-code-141-with-grep-q
@Alex-Welsh
Copy link
Member

What's pointing you towards this task? This error seems to imply a more general problem with disk space: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/12787679531/job/35647364902#step:30:223

@MoteHue
Copy link
Contributor Author

MoteHue commented Jan 15, 2025 •
edited
Loading

What's pointing you towards this task? This error seems to imply a more general problem with disk space: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/12787679531/job/35647364902#step:30:223

It looks to me that there isn't enough space for the LVM config because the root hasn't been grown to fill the disk.
Sorry, didn't save output but lsblk showed vda3 was on 20G out of the 100G disk

@MoteHue
Copy link
Contributor Author

MoteHue commented Jan 15, 2025

What's pointing you towards this task? This error seems to imply a more general problem with disk space: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/12787679531/job/35647364902#step:30:223

It looks to me that there isn't enough space for the LVM config because the root hasn't been grown to fill the disk. Sorry, didn't save output but lsblk showed vda3 was on 20G out of the 100G disk

Something like:

stack@wazuh-test-mn-seed:~$ lsblk
NAME                  MAJ:MIN RM  SIZE RO TYPE MOUNTPOINTS
sr0                    11:0    1  524K  0 rom  
vda                   252:0    0  100G  0 disk 
├─vda1                252:1    0  500M  0 part /boot/efi
├─vda2                252:2    0    8M  0 part 
└─vda3                252:3    0 20G  0 part 
  ├─rootvg-lv_root    253:0    0   10G  0 lvm  /
  ├─rootvg-lv_tmp     253:1    0  952M  0 lvm  /tmp
  ├─rootvg-lv_var     253:2    0  952M  0 lvm  /var
  ├─rootvg-lv_var_tmp 253:3    0  952M  0 lvm  /var/tmp
  ├─rootvg-lv_log     253:4    0  952M  0 lvm  /var/log
  ├─rootvg-lv_audit   253:5    0  120M  0 lvm  /var/log/audit
  ├─rootvg-lv_home    253:6    0  120M  0 lvm  /home
  └─rootvg-lv_swap    253:7    0    1G  0 lvm

@Alex-Welsh Alex-Welsh merged commit e814461 into stackhpc/2024.1 Jan 16, 2025
14 checks passed
@Alex-Welsh Alex-Welsh deleted the seed-fix-growroot branch January 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Welsh Alex-Welsh Alex-Welsh approved these changes

Assignees
No one assigned
Labels
ansible Ansible playbooks size: xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoteHue @Alex-Welsh