Skip to content

Make SMS the default runner environment #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2025
Merged

Make SMS the default runner environment #1646

merged 4 commits into from
May 20, 2025

Conversation

MaxBed4d
Copy link
Contributor

No description provided.

@MaxBed4d MaxBed4d requested a review from a team as a code owner May 14, 2025 08:22
@product-auto-label product-auto-label bot added size: s workflows Workflow files have been modified labels May 14, 2025
@Alex-Welsh
Copy link
Member

It obviously works, but do you know why this says the env is SMS for an upgrade job? Just a visual bug maybe? https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/15069754840/job/42364136409?pr=1646#step:1:18

@MaxBed4d
Copy link
Contributor Author

It obviously works, but do you know why this says the env is SMS for an upgrade job? Just a visual bug maybe? stackhpc/stackhpc-kayobe-config/actions/runs/15069754840/job/42364136409?pr=1646#step:1:18

Because the default input for the chosen environment, I don't think, can be defined by a ternary operator dependent on another input variable (upgrade) being defined at the same time. Therefore, the default for the environment input (SMS) corresponds appropriately to the upgrade variable default (false), and so only when the upgrade is set to true do we need to change the environment from the default.

We could remove the input all together and define the environment in the ternary operator but, considering we are planning a full move to SMS of all tasks, this will be required.

@Alex-Welsh Alex-Welsh marked this pull request as ready for review May 20, 2025 15:12
@Alex-Welsh Alex-Welsh merged commit a9b8224 into stackhpc/2024.1 May 20, 2025
31 checks passed
@Alex-Welsh Alex-Welsh deleted the arc-aio branch May 20, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Welsh Alex-Welsh Alex-Welsh approved these changes

Assignees
No one assigned
Labels
size: s workflows Workflow files have been modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxBed4d @Alex-Welsh