Fix PCI passthrough default templates #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoteHue
approved these changes
May 14, 2025
MoteHue
requested changes
May 14, 2025
seunghun1ee
force-pushed
the
fix-pci-default-template
branch
2 times, most recently
from
9ce543f to
d0b4b53
Compare
Alex-Welsh
approved these changes
May 14, 2025
Even though the variable ``gpu_group_map`` has default value of {}
defined at stackhpc-compute.yml, it can be set to anything by users.
Therefore, Using dict2items filter with it can cause unexpected
templating error.
Fixing this by setting {} as a default of ``gpu_group_map`` before
using dict2items filter.
So even if ``gpu_group_map`` becomes undefined for some reason, it
doesn't fail in run time.
seunghun1ee
force-pushed
the
fix-pci-default-template
branch
from
d0b4b53 to
a812b7c
Compare
MoteHue
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the variable
gpu_group_maphas default value of {} defined at stackhpc-compute.yml, it can be set to anything by users. Therefore, Using dict2items filter with it can cause unexpected templating error.Fixing this by setting {} as a default of
gpu_group_mapbefore using dict2items filter.So even if
gpu_group_mapbecomes undefined for some reason, it doesn't fail in run time.