Skip to content

Configure IPA with useful inspection settings #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

priteau
Copy link
Member

@priteau priteau commented Oct 11, 2022

Add configuration to include extra-hardware and mellanox elements, with other useful collectors and kernel settings.

@priteau priteau self-assigned this Oct 11, 2022
@priteau priteau requested a review from a team as a code owner October 11, 2022 13:03
@markgoddard
Copy link
Contributor

What should we do here?

@priteau
Copy link
Member Author

priteau commented Sep 28, 2023

What should we do here?

Are we still planning to build IPA images and host them on Ark?

@markgoddard
Copy link
Contributor

What should we do here?

Are we still planning to build IPA images and host them on Ark?

That is in the plan, although not scheduled in the near future.

@priteau
Copy link
Member Author

priteau commented Sep 28, 2023

What should we do here?

Are we still planning to build IPA images and host them on Ark?

That is in the plan, although not scheduled in the near future.

Thanks. I need to revisit this because IPA images on recent releases will use CentOS Stream 9.

@priteau priteau changed the base branch from stackhpc/wallaby to stackhpc/2023.1 September 16, 2024 15:36
@priteau priteau changed the title Configure IPA with extra-hardware benchmarks Configure IPA with useful inspection settings Sep 16, 2024
@priteau priteau force-pushed the ipa-extra-hardware branch 2 times, most recently from 63497fc to ded7419 Compare September 16, 2024 15:44
MoteHue
MoteHue previously approved these changes Sep 16, 2024
Copy link
Contributor

@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add configuration to include extra-hardware and mellanox elements, with
other useful collectors and kernel settings.
@MoteHue MoteHue force-pushed the ipa-extra-hardware branch from de446cb to 19207e1 Compare October 11, 2024 12:33
@Alex-Welsh
Copy link
Member

I've resolved the final conversation so this is now mergable, but it was last approved over a month ago. @priteau or @MoteHue could you quickly check it's not stale since then, and click the button?

@MoteHue
Copy link
Contributor

MoteHue commented Nov 12, 2024

I've resolved the final conversation so this is now mergable, but it was last approved over a month ago. @priteau or @MoteHue could you quickly check it's not stale since then, and click the button?

Still LGTM, let's merge :)

@Alex-Welsh Alex-Welsh merged commit f945151 into stackhpc/2023.1 Nov 12, 2024
12 checks passed
@Alex-Welsh Alex-Welsh deleted the ipa-extra-hardware branch November 12, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants