Skip to content

Add wazuh #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Apr 13, 2023
Merged

Add wazuh #318

merged 39 commits into from
Apr 13, 2023

Conversation

GregWhiteyBialas
Copy link
Contributor

No description provided.

@GregWhiteyBialas GregWhiteyBialas requested a review from a team as a code owner January 4, 2023 14:51
@markgoddard
Copy link
Contributor

I haven't reviewed this yet, but probably it needs to support Ubuntu as well as CentOS, to avoid breaking deployments using Ubuntu. I ended up with a slightly different pattern for Ubuntu (most recently used at RUG), and Jack had problems using the more recent ansible-wazuh roles.

@mnasiadka
Copy link
Member

I think we need to start somewhere, should we have a disclaimer for now, that it shouldn't be used on Ubuntu and have a task to test it out?

@markgoddard
Copy link
Contributor

I think we need to start somewhere, should we have a disclaimer for now, that it shouldn't be used on Ubuntu and have a task to test it out?

I would agree if the playbooks & config didn't conflict with those used on Ubuntu. We have started somewhere - kayobe-ops. To do it in s-k-c it needs to support Ubuntu IMO

@mnasiadka
Copy link
Member

Is this ready for reviews?

@GregWhiteyBialas
Copy link
Contributor Author

@mnasiadka It is.

g0rgamesh
g0rgamesh previously approved these changes Mar 30, 2023
Copy link
Contributor

@g0rgamesh g0rgamesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need a release note.

@GregWhiteyBialas
Copy link
Contributor Author

GregWhiteyBialas commented Apr 6, 2023

For the record. Three candidates for followup tasks:

  • copy certs only on the first/initial deployment
  • support for RL9
  • update to wazuh-ansible version 4.4 and use upstream roles

Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's get this one in. Thanks for persevering.

@GregWhiteyBialas GregWhiteyBialas merged commit 8bfb7bd into stackhpc/xena Apr 13, 2023
@GregWhiteyBialas GregWhiteyBialas deleted the add_wazuh branch April 13, 2023 09:29
Comment on lines +47 to +48
etc/kayobe/ansible/wazuh/certificates/*
etc/kayobe/ansible/wazuh/certificates/custom_certificates/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about these two again, won't this make it likely we forget to add the certs to git? Are there any autogenerated cert files we need to ignore? I expect we'd want to add all custom certs though?

@markgoddard markgoddard mentioned this pull request Apr 13, 2023
@markgoddard markgoddard mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants