-
Notifications
You must be signed in to change notification settings - Fork 23
Add wazuh #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wazuh #318
Conversation
I haven't reviewed this yet, but probably it needs to support Ubuntu as well as CentOS, to avoid breaking deployments using Ubuntu. I ended up with a slightly different pattern for Ubuntu (most recently used at RUG), and Jack had problems using the more recent ansible-wazuh roles. |
I think we need to start somewhere, should we have a disclaimer for now, that it shouldn't be used on Ubuntu and have a task to test it out? |
I would agree if the playbooks & config didn't conflict with those used on Ubuntu. We have started somewhere - kayobe-ops. To do it in s-k-c it needs to support Ubuntu IMO |
Is this ready for reviews? |
6644379
to
6f2438f
Compare
@mnasiadka It is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jack Hodgkiss <[email protected]>
Co-authored-by: Jack Hodgkiss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need a release note.
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
Co-authored-by: Mark Goddard <[email protected]>
For the record. Three candidates for followup tasks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's get this one in. Thanks for persevering.
etc/kayobe/ansible/wazuh/certificates/* | ||
etc/kayobe/ansible/wazuh/certificates/custom_certificates/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about these two again, won't this make it likely we forget to add the certs to git? Are there any autogenerated cert files we need to ignore? I expect we'd want to add all custom certs though?
No description provided.