Add Trivy image scanning #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Alex-Welsh merged 26 commits into stackhpc/yoga from feat/trivy-image-scanning-test

Mar 8, 2024

Member

JohnGarbutt commented Mar 9, 2023

No description provided.

k-s-dean added 13 commits

March 2, 2023 11:36


          Trivy scanning

75c2a7d


          Fix Trivy install permissions


          remove push for testing

290b0e7


          fix input

82bb994


          fix incorrect path

78e0eb9


          missing sudo

3fab758


          Bump trivy version

5fac63e


          try folder upload for sarif files

c20bf35


          Test

ed8284e


          Test

e553791


          test

60d54d9


          test

0addd68


          test

df003de

JohnGarbutt commented

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

JohnGarbutt commented

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

JohnGarbutt commented

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

JohnGarbutt commented

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

JohnGarbutt commented

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

markgoddard suggested changes

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

k-s-dean and others added 6 commits

March 9, 2023 12:50


          Code clean up and fixes


          add push back

c730780


          Get images to scan for seed and overcloud

5f2ff76


          Merge branch 'stackhpc/yoga' into feat/trivy-image-scanning-test

a0ccf84


          Separate image build and push steps

a83e64e


          Merge branch 'stackhpc/yoga' into feat/trivy-image-scanning-test

dd34768

m-bull force-pushed the feat/trivy-image-scanning-test branch 3 times, most recently from df92e3b to f5d13f3 Compare

August 3, 2023 21:15


          Correct workflow syntax

1a9ab2e

m-bull force-pushed the feat/trivy-image-scanning-test branch from f5d13f3 to 1a9ab2e Compare

August 4, 2023 08:25

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch 3 times, most recently from 4c92f5f to 58f12e7 Compare

March 4, 2024 11:16

Alex-Welsh marked this pull request as ready for review

March 4, 2024 12:32

Member

Alex-Welsh commented Mar 4, 2024

Same deal as before, two test workflows. One pushing dodgy images, one not:
Only pushing clean images
Pushing everything

Contributor

markgoddard commented Mar 4, 2024

From meeting: print out a list of dirty images if we fail.

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch from 58f12e7 to 0d64c6c Compare

March 4, 2024 14:33

Member

Alex-Welsh commented Mar 4, 2024 •

edited

Loading

Successful test of the latest changes to print out a list of failed pushes & scans -> https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/8141944049/job/22250383251

Member

Alex-Welsh commented Mar 4, 2024

From meeting: print out a list of dirty images if we fail.

Done

markgoddard suggested changes

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch from 0d64c6c to fda30aa Compare

March 5, 2024 16:49

markgoddard suggested changes

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch 2 times, most recently from 3a8d239 to 1884635 Compare

March 6, 2024 12:06


          Container image builds misc improvements

c032f68

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch 2 times, most recently from fc96699 to 823411d Compare

March 6, 2024 15:33

Member

Alex-Welsh commented Mar 6, 2024

That's enough fiddling. Ready for review again. All images are building now which is nice: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/8174658638

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch 3 times, most recently from 24acc01 to 7c401ba Compare

March 7, 2024 15:15

Alex-Welsh enabled auto-merge (squash)

March 7, 2024 16:01

Alex-Welsh requested a review from markgoddard

March 8, 2024 08:31

markgoddard reviewed

View reviewed changes

.github/workflows/stackhpc-container-image-build.yml Outdated Show resolved Hide resolved


          Kolla image build - improve output formatting

2be1d27

Alex-Welsh force-pushed the feat/trivy-image-scanning-test branch from 7c401ba to 2be1d27 Compare

March 8, 2024 14:13

markgoddard approved these changes

View reviewed changes

Contributor

markgoddard left a comment

Let's get scanning.

Alex-Welsh merged commit fcfff10 into stackhpc/yoga

Alex-Welsh deleted the feat/trivy-image-scanning-test branch

March 8, 2024 14:16

markgoddard mentioned this pull request

2024.1: 2023.1 merge #1052

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet