Skip to content

Use workflow images in aio ci #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2023
Merged

Use workflow images in aio ci #515

merged 2 commits into from
Jun 30, 2023

Conversation

Alex-Welsh
Copy link
Member

@Alex-Welsh Alex-Welsh commented May 15, 2023 •
edited
Loading

This PR is not yet ready for review, I just want to run the CI and test it

@Alex-Welsh Alex-Welsh force-pushed the aio-images branch 2 times, most recently from 4e90ca2 to 199c024 Compare May 16, 2023 08:08
markgoddard
markgoddard reviewed May 16, 2023
View reviewed changes
@Alex-Welsh Alex-Welsh force-pushed the aio-images branch 4 times, most recently from f434b6b to c9f78e5 Compare May 17, 2023 09:22
@Alex-Welsh Alex-Welsh force-pushed the aio-images branch 23 times, most recently from 4fec4ac to dab66f1 Compare May 25, 2023 15:43
@Alex-Welsh Alex-Welsh force-pushed the aio-images branch 9 times, most recently from 54ad5a1 to 9bc8555 Compare June 26, 2023 13:17
@Alex-Welsh Alex-Welsh marked this pull request as ready for review June 26, 2023 13:18
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner June 26, 2023 13:18
@Alex-Welsh
Copy link
Member Author

Last thing to do is set a reasonable size for the runner disk. I'll keep letting the CI run and bump it by 5gb every time it fails. Should only take a couple of tries.

markgoddard
markgoddard suggested changes Jun 26, 2023
View reviewed changes
@markgoddard
Copy link
Contributor

The Rocky 8 jobs seem to be failing to boot.

@Alex-Welsh Alex-Welsh changed the title WIP: Use workflow images in aio ci Use workflow images in aio ci Jun 27, 2023
@Alex-Welsh
Copy link
Member Author

The Rocky 8 jobs seem to be failing to boot.

It's also failing to build a new image because of an unrelated issue. More yak shaving on the horizon

@markgoddard
Copy link
Contributor

Rocky 8 image still failing.

Required checks will need updating following the ubuntu job rename. Currently these are required across all branches, so it would need to be an intersection of jobs between releases. Maybe consider not changing the focal job name to avoid this issue? https://github.com/stackhpc/stackhpc-release-train/blob/main/terraform/github/terraform.tfvars.json#L314

@Alex-Welsh
Copy link
Member Author

Rocky 8 image still failing.

I'd like to build a new image but it's currently failing due to the openstacksdk python3.6 break upstream. I'd rather not put in a temporary fix when it won't be necessary for long.

Required checks will need updating following the ubuntu job rename. Currently these are required across all branches, so it would need to be an intersection of jobs between releases. Maybe consider not changing the focal job name to avoid this issue? https://github.com/stackhpc/stackhpc-release-train/blob/main/terraform/github/terraform.tfvars.json#L314

Ah, I was wondering where those were defined. I'll revert the name change for the focal jobs, and look into expanding the required checks for stackhpc/yoga only

@markgoddard
Copy link
Contributor

Required checks will need updating following the ubuntu job rename. Currently these are required across all branches, so it would need to be an intersection of jobs between releases. Maybe consider not changing the focal job name to avoid this issue? https://github.com/stackhpc/stackhpc-release-train/blob/main/terraform/github/terraform.tfvars.json#L314

Ah, I was wondering where those were defined. I'll revert the name change for the focal jobs, and look into expanding the required checks for stackhpc/yoga only

Currently we can't do per-branch required checks. I don't think it's a big deal for now.

@Alex-Welsh Alex-Welsh force-pushed the aio-images branch 2 times, most recently from ef17498 to cb621f5 Compare June 29, 2023 15:19
@Alex-Welsh
Use workflow images in aio ci
ae6645d 
This change begins using stackhpc-built images in AIO CI jobs.

The disk size of the AIO runners is minimised, and an LVM
configuration is now included in the AIO environment.

Minor improvements to the build process and AIO configuration are
included to allow the CI tests to pass.
@Alex-Welsh
Update AIO workflow based on review comments
aa2e5da
@Alex-Welsh
Copy link
Member Author

The openstacksdk bug was fixed upstream yesterday, so I rebuilt the Rocky 8 image and everything is passing

@Alex-Welsh Alex-Welsh requested a review from markgoddard June 30, 2023 09:17
markgoddard
markgoddard approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Alex-Welsh Alex-Welsh merged commit 4c868dd into stackhpc/yoga Jun 30, 2023
@Alex-Welsh Alex-Welsh deleted the aio-images branch June 30, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-Welsh @markgoddard