-
Notifications
You must be signed in to change notification settings - Fork 23
Refactor tag overrides #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've been using this to test the migration from CS8 to RL9. I'm not sure if it needs to be merged into our main branches given that we also have mark's full tag refactor on the horizon. https://github.com/stackhpc/stackhpc-kayobe-config/tree/wallaby-kolla-build-improvements |
596d284
to
2f43998
Compare
2f43998
to
506224e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing octavia from https://github.com/stackhpc/stackhpc-kayobe-config/pull/524/files
89da158
to
eb91566
Compare
Fixed |
d59f932
to
d30e726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pep8 doesn't like it:
ValueError: 94b83c151902cd5f: found several files in one commit (b'd30e726c573429633e851a71bb619f48821ae83a') with the same UID: ['refactor-tag-overrides-94b83c151902cd5f.yaml', 'refactor-tag-overrides-94b83c151902cd5f.yaml']
24f4a11
to
aa26c9c
Compare
This refactor includes two changes The first sets kolla_base_distro according to ansible facts, and is resolved by kolla-ansible on a host by host basis. The second reformats the existing structure for override tags, again allowing kolla-ansible to resolve them on a host by host basis. The result of these two changes is that clouds with with mixed host distributions can be deployed. This is relevant when performing a rolling migration between two distributions.
aa26c9c
to
3fcac5d
Compare
Tox has stopped complaining now. Not sure what happened there |
This PR is cursed |
Rocky 8 failing on MariaDB unrelated:
|
This refactor includes two changes
The first sets kolla_base_distro according to ansible facts, and is resolved by kolla-ansible on a host by host basis.
The second reformats the existing structure for override tags, again allowing kolla-ansible to resolve them on a host by host basis.
The result of these two changes is that clouds with with mixed host distributions can be deployed.
This is relevant when performing a rolling migration between two distributions.