Skip to content

Refactor tag overrides #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023
Merged

Refactor tag overrides #520

merged 1 commit into from
May 25, 2023

Conversation

Alex-Welsh
Copy link
Member

This refactor includes two changes

The first sets kolla_base_distro according to ansible facts, and is resolved by kolla-ansible on a host by host basis.

The second reformats the existing structure for override tags, again allowing kolla-ansible to resolve them on a host by host basis.

The result of these two changes is that clouds with with mixed host distributions can be deployed.

This is relevant when performing a rolling migration between two distributions.

@Alex-Welsh
Copy link
Member Author

Alex-Welsh commented May 16, 2023

I've been using this to test the migration from CS8 to RL9. I'm not sure if it needs to be merged into our main branches given that we also have mark's full tag refactor on the horizon. https://github.com/stackhpc/stackhpc-kayobe-config/tree/wallaby-kolla-build-improvements

@Alex-Welsh Alex-Welsh force-pushed the refactor-tag-overrides branch 2 times, most recently from 596d284 to 2f43998 Compare May 17, 2023 08:54
markgoddard
markgoddard previously approved these changes May 17, 2023
@Alex-Welsh Alex-Welsh marked this pull request as ready for review May 17, 2023 09:05
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner May 17, 2023 09:05
@Alex-Welsh Alex-Welsh force-pushed the refactor-tag-overrides branch from 2f43998 to 506224e Compare May 23, 2023 09:44
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-Welsh Alex-Welsh force-pushed the refactor-tag-overrides branch 2 times, most recently from 89da158 to eb91566 Compare May 24, 2023 09:10
@Alex-Welsh Alex-Welsh requested a review from markgoddard May 24, 2023 09:11
@Alex-Welsh
Copy link
Member Author

@Alex-Welsh Alex-Welsh enabled auto-merge May 24, 2023 09:13
@Alex-Welsh Alex-Welsh force-pushed the refactor-tag-overrides branch from d59f932 to d30e726 Compare May 24, 2023 09:20
@Alex-Welsh Alex-Welsh disabled auto-merge May 24, 2023 09:20
@Alex-Welsh Alex-Welsh enabled auto-merge (squash) May 24, 2023 09:20
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8 doesn't like it:

ValueError: 94b83c151902cd5f: found several files in one commit (b'd30e726c573429633e851a71bb619f48821ae83a') with the same UID: ['refactor-tag-overrides-94b83c151902cd5f.yaml', 'refactor-tag-overrides-94b83c151902cd5f.yaml']

@Alex-Welsh Alex-Welsh force-pushed the refactor-tag-overrides branch 2 times, most recently from 24f4a11 to aa26c9c Compare May 25, 2023 10:01
This refactor includes two changes

The first sets kolla_base_distro according to ansible facts, and is
resolved by kolla-ansible on a host by host basis.

The second reformats the existing structure for override tags,
again allowing kolla-ansible to resolve them on a host by host basis.

The result of these two changes is that clouds with with mixed host
distributions can be deployed.

This is relevant when performing a rolling migration between two
distributions.
@Alex-Welsh Alex-Welsh force-pushed the refactor-tag-overrides branch from aa26c9c to 3fcac5d Compare May 25, 2023 10:07
@Alex-Welsh
Copy link
Member Author

Tox has stopped complaining now. Not sure what happened there

@Alex-Welsh
Copy link
Member Author

This PR is cursed

@markgoddard markgoddard disabled auto-merge May 25, 2023 12:34
@markgoddard markgoddard merged commit 020f94a into stackhpc/yoga May 25, 2023
@markgoddard markgoddard deleted the refactor-tag-overrides branch May 25, 2023 12:34
@markgoddard
Copy link
Contributor

Rocky 8 failing on MariaDB unrelated:

TASK [mariadb : Wait for MariaDB service to be ready through VIP] **************
Thursday 25 May 2023  10:44:21 +0000 (0:00:03.279)       0:06:39.757 ********** 
FAILED - RETRYING: Wait for MariaDB service to be ready through VIP (6 retries left).
FAILED - RETRYING: Wait for MariaDB service to be ready through VIP (5 retries left).
FAILED - RETRYING: Wait for MariaDB service to be ready through VIP (4 retries left).
FAILED - RETRYING: Wait for MariaDB service to be ready through VIP (3 retries left).
FAILED - RETRYING: Wait for MariaDB service to be ready through VIP (2 retries left).
FAILED - RETRYING: Wait for MariaDB service to be ready through VIP (1 retries left).
fatal: [controller0]: FAILED! => changed=false 
  attempts: 6
  cmd:
  - docker
  - exec
  - mariadb
  - mysql
  - -h
  - 192.168.33.2
  - -P
  - '3306'
  - -u
  - root
  - -piDULu9XXb9VssTIVEEml41mUr2eldZBroLJUqzX8
  - -e
  - show databases;
  delta: '0:00:00.303536'
  end: '2023-05-25 10:45:30.898725'
  msg: non-zero return code
  rc: 1
  start: '2023-05-25 10:45:30.595189'
  stderr: 'ERROR 2013 (HY000): Lost connection to server at ''handshake: reading initial communication packet'', system error: 11'
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants