Skip to content

Add playbooks to allow hotfixing containers #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Jun 20, 2023

No description provided.

@Alex-Welsh
Copy link
Member

Added docs

@Alex-Welsh Alex-Welsh marked this pull request as ready for review June 21, 2023 09:32
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner June 21, 2023 09:32
@MoteHue MoteHue force-pushed the hotfix-containers-playbook branch 2 times, most recently from c3b8e78 to ef7de49 Compare June 21, 2023 11:27
@Alex-Welsh
Copy link
Member

For the record, I'm not happy with how regex is handled, and the way it needs to match the entire name not just a substring. I don't know of a better way to do it though so any suggestions are more than welcome

@Alex-Welsh Alex-Welsh force-pushed the hotfix-containers-playbook branch from 0fa4a33 to 33da0e0 Compare June 21, 2023 11:36
@JohnGarbutt
Copy link
Member

So it's a bit late for this comment, but we could generate an image with a thin delta that is just the proposed hot fix, then push that image everywhere? We get to more easily track where it is applied then

@Alex-Welsh
Copy link
Member

So it's a bit late for this comment, but we could generate an image with a thin delta that is just the proposed hot fix, then push that image everywhere? We get to more easily track where it is applied then

I'd be interested to hear other opinions but in my mind it might be an "as well as" rather than an "instead of". This playbook should really only be a last resort if we urgently need to get something out.

I can see the two different workflows being:
Major issue discovered -> hotfix with this playbook -> get longer term fix into release train.
Minor issue discovered -> generate new image & diff -> roll out to deployments

@MoteHue
Copy link
Contributor Author

MoteHue commented Jun 21, 2023

in my mind it might be an "as well as" rather than an "instead of"

I'd agree with this. This hotfix playbook isn't meant to be the one true solution to urgently resolving a critical issue/vulnerability.

@Alex-Welsh Alex-Welsh force-pushed the hotfix-containers-playbook branch from 06e91b6 to ab53a11 Compare June 23, 2023 08:40
@markgoddard
Copy link
Contributor

So it's a bit late for this comment, but we could generate an image with a thin delta that is just the proposed hot fix, then push that image everywhere? We get to more easily track where it is applied then

It's an interesting alternative, since it reduces the risk of losing the temporary changes in the hotfix. I think the (your) intention here was for this to allow getting fixes out for zero day issues as fast as possible. If we need to build and distribute an image then it's going to take longer, and at some (unknown) point we might as well build images from scratch and do it "properly".

@Alex-Welsh Alex-Welsh force-pushed the hotfix-containers-playbook branch from ab53a11 to 1c5c627 Compare June 30, 2023 11:12
@Alex-Welsh Alex-Welsh force-pushed the hotfix-containers-playbook branch from 1c5c627 to aa1b171 Compare June 30, 2023 13:03
@MoteHue MoteHue requested review from jovial and markgoddard July 28, 2023 10:23
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it! Just one issue with the fail task.

@markgoddard markgoddard merged commit 3a33494 into stackhpc/yoga Aug 2, 2023
@markgoddard markgoddard deleted the hotfix-containers-playbook branch August 2, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants