Skip to content

Update/smartmon playbook #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Update/smartmon playbook #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be5831
Add check to ensure cron is installed
technowhizz Jun 23, 2023
111d163
Add release note
technowhizz Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion etc/kayobe/ansible/smartmon-tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
- hosts: overcloud

tasks:
- name: Ensure smartmon-tools and nvme-cli is installed
- name: Ensure smartmon-tools, jq, nvme-cli and cron/cronie is installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I usually just put "packages" or "package dependencies" :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Will bear in mind for next time

package:
name:
- smartmontools
- nvme-cli
- jq
- "{{ 'cron' if ansible_facts['distribution'] == 'Ubuntu' else 'cronie' }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using ansible_facts['os_family'] == 'Debian' might be more generic, but given that that we only support Ubuntu/Redhat this looks OK.

state: present
become: true

Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/update-smartmon-playbook-6bdf9624c579d2e2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
upgrade:
- |
Updates the smartmon-tools.yml playbook to ensure that cron is installed
before attempting to configure crontab.