-
Notifications
You must be signed in to change notification settings - Fork 23
Support using local hashicorp consul/vault images #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af893d1
to
01bc3b9
Compare
This requires stackhpc.hashicorp 2.4.0.
01bc3b9
to
d5502bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Only thought was that if we mirror the images from dockerhub directly, instead of pulling via ark, that we might end of using different versions of the images at different deployments. Not sure if they rebuild the images with the same tags?
I followed the approach we use for Ceph images. From what I can see on Docker Hub, if we switched to patch-level version (e.g. 1.14.1 instead of 1.14) we should get the same images:
|
I think it still would be better to sync those to Ark for internet-constrained environments (and counting docker hub pull limits) |
Perhaps, but it could be done as a separate task. |
This requires stackhpc.hashicorp 2.4.0.