Skip to content

Support using local hashicorp consul/vault images #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

priteau
Copy link
Member

@priteau priteau commented Aug 1, 2023

This requires stackhpc.hashicorp 2.4.0.

@priteau priteau self-assigned this Aug 1, 2023
@priteau priteau marked this pull request as ready for review August 2, 2023 10:02
@priteau priteau requested a review from a team as a code owner August 2, 2023 10:02
mnasiadka
mnasiadka previously approved these changes Aug 2, 2023
This requires stackhpc.hashicorp 2.4.0.
@priteau priteau requested a review from jovial August 9, 2023 09:06
Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Only thought was that if we mirror the images from dockerhub directly, instead of pulling via ark, that we might end of using different versions of the images at different deployments. Not sure if they rebuild the images with the same tags?

@priteau
Copy link
Member Author

priteau commented Aug 9, 2023

Looks reasonable to me. Only thought was that if we mirror the images from dockerhub directly, instead of pulling via ark, that we might end of using different versions of the images at different deployments. Not sure if they rebuild the images with the same tags?

I followed the approach we use for Ceph images. From what I can see on Docker Hub, if we switched to patch-level version (e.g. 1.14.1 instead of 1.14) we should get the same images:

  • 1.14.0 was pushed on June 21 (day of 1.14.0 release)
  • 1.14.1 was pushed on July 25 (when it was released)
  • 1.14 was updated to point to 1.14.1

@mnasiadka
Copy link
Member

I think it still would be better to sync those to Ark for internet-constrained environments (and counting docker hub pull limits)

@markgoddard markgoddard merged commit eaad4bd into stackhpc/yoga Aug 10, 2023
@markgoddard markgoddard deleted the hashicorp-images branch August 10, 2023 09:21
@markgoddard
Copy link
Contributor

I think it still would be better to sync those to Ark for internet-constrained environments (and counting docker hub pull limits)

Perhaps, but it could be done as a separate task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants