Skip to content

yoga: xena merge #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 17, 2023
Merged

yoga: xena merge #590

merged 17 commits into from
Aug 17, 2023

Conversation

priteau
Copy link
Member

@priteau priteau commented Aug 17, 2023

  • Cap number of Pulp workers
  • Fix documentation builds on Read the Docs

MoteHue and others added 17 commits June 6, 2023 10:07
Correct Manila backend variable in multinode docs
Running Pulp with a number of workers based on CPUs can cause errors
such as PostgreSQL connection limits on hosts with many cores:

    psycopg.OperationalError: connection failed: FATAL:  remaining connection slots are reserved for non-replication superuser connections

Cap workers to 32 until large scale testing can identify a more suitable
limit.
Fix documentation builds on Read the Docs
The default Python version has changed from 3.7 to 3.11 when updating
Read the Docs configuration. See the announcement of configuration file
version 2 for more details [1].

[1] https://blog.readthedocs.com/migrate-configuration-v2/
Attempt to fix RTD failures using Python 3.7
Read the Docs does not perform a full clone on checkout job to reduce
network data and speed up the build process. Because of this, extensions
that depend on the full Git history will fail [1].

This breaks build of release notes, since reno needs Git history access.

[1] https://docs.readthedocs.io/en/stable/build-customization.html#unshallow-git-clone
The Git shallow clone used on Read the Docs is configured to only fetch
a specific Git branch:

[remote "origin"]
	url = https://github.com/stackhpc/stackhpc-kayobe-config.git
	fetch = +refs/heads/stackhpc/yoga:refs/remotes/origin/stackhpc/yoga

This prevents subsequent `git fetch` commands from fetching all remote
branches. Use `git remote set-branches origin '*'` to revert to the
default Git fetch configuration.
Restore default Git fetch configuration on RTD
The wildcard glob matched files in the current directory which resulted
in `git fetch` failing with:

    fatal: couldn't find remote ref refs/heads/LICENSE
Escape wildcard character in custom build command
Use an explicit list of remote branches with release notes instead of a
wildcard which is behaving differently on Read the Docs than locally.

Also remove true fallback to fail early.
Work around Read the Docs wildcard escaping issues
@priteau priteau requested a review from a team as a code owner August 17, 2023 07:22
@priteau priteau self-assigned this Aug 17, 2023
@priteau priteau requested a review from markgoddard August 17, 2023 09:00
@markgoddard markgoddard merged commit ea5ac06 into stackhpc/yoga Aug 17, 2023
@markgoddard markgoddard deleted the yoga-xena-merge branch August 17, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants