Skip to content

rebuild opensearch images #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023
Merged

rebuild opensearch images #618

merged 1 commit into from
Sep 6, 2023

Conversation

@bbezak bbezak requested a review from a team as a code owner September 6, 2023 07:35
@mnasiadka
Copy link
Member

Should we add opensearch repo to Ark?

@Alex-Welsh
Copy link
Member

Alex-Welsh commented Sep 6, 2023

@mnasiadka
Copy link
Member

Should we add opensearch repo to Ark?

It's already there https://github.com/stackhpc/stackhpc-release-train/blob/e3eff5b0be002b0499bab8cdbb63e52603071b78/ansible/inventory/group_vars/all/package-repos#L638

But we also need the template overrides and repo versions in SKC stackhpc/yoga, right?

@Alex-Welsh
Copy link
Member

Should we add opensearch repo to Ark?

It's already there https://github.com/stackhpc/stackhpc-release-train/blob/e3eff5b0be002b0499bab8cdbb63e52603071b78/ansible/inventory/group_vars/all/package-repos#L638

But we also need the template overrides and repo versions in SKC stackhpc/yoga, right?

Yes, they will need to be added to places like pulp.yml,pulp-repo-versions.yml, and kolla.ymlto actually use them

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rm line 61: opensearch_tag: "{% raw %}{{ kayobe_image_tags['opensearch'][kolla_base_distro] | default(openstack_tag) }}{% endraw %}" no longer necessary now the tag isn't in the kayobe_image_tags dict

@bbezak
Copy link
Member Author

bbezak commented Sep 6, 2023

You can rm line 61: opensearch_tag: "{% raw %}{{ kayobe_image_tags['opensearch'][kolla_base_distro] | default(openstack_tag) }}{% endraw %}" no longer necessary now the tag isn't in the kayobe_image_tags dict

done, thx

Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hoping to rebase my change on this one, so keen to get it merged.

@bbezak
Copy link
Member Author

bbezak commented Sep 6, 2023

LGTM. Hoping to rebase my change on this one, so keen to get it merged.

however I'm not sure if the tags in current versions are acceptable - as this build used upstream opensearch repos (not ark ones)

@markgoddard
Copy link
Contributor

LGTM. Hoping to rebase my change on this one, so keen to get it merged.

however I'm not sure if the tags in current versions are acceptable - as this build used upstream opensearch repos (not ark ones)

Let's go with upstream repos for now.

@bbezak
Copy link
Member Author

bbezak commented Sep 6, 2023

when this merges, we need to also revert revert stackhpc/kolla-ansible#427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants