-
Notifications
You must be signed in to change notification settings - Fork 23
rebuild opensearch images #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we add opensearch repo to Ark? |
35574ae
to
aace640
Compare
It's already there https://github.com/stackhpc/stackhpc-release-train/blob/e3eff5b0be002b0499bab8cdbb63e52603071b78/ansible/inventory/group_vars/all/package-repos#L638 |
But we also need the template overrides and repo versions in SKC stackhpc/yoga, right? |
Yes, they will need to be added to places like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can rm line 61: opensearch_tag: "{% raw %}{{ kayobe_image_tags['opensearch'][kolla_base_distro] | default(openstack_tag) }}{% endraw %}"
no longer necessary now the tag isn't in the kayobe_image_tags
dict
aace640
to
e538789
Compare
done, thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hoping to rebase my change on this one, so keen to get it merged.
however I'm not sure if the tags in current versions are acceptable - as this build used upstream opensearch repos (not ark ones) |
Let's go with upstream repos for now. |
when this merges, we need to also revert revert stackhpc/kolla-ansible#427 |
preparation for https://review.opendev.org/c/openstack/kolla-ansible/+/884376
build with:
https://review.opendev.org/c/openstack/kolla/+/883716
stackhpc/kolla@23e0819
build: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/6072058437
promote: https://github.com/stackhpc/stackhpc-release-train/actions/runs/6094062526