Skip to content

Fix zed host image build workflow #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix zed host image build workflow #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/overcloud-host-image-build.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these fixes go back to yoga?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's running fine without them, probably because it uses the old CS8 runners

Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ jobs:
runs-on: [self-hosted, stackhpc-kayobe-config-kolla-builder-rl9]
permissions: {}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
path: src/kayobe-config

- name: Determine OpenStack release
id: openstack_release
run: |
BRANCH=$(awk -F'=' '/defaultbranch/ {print $2}' .gitreview)
BRANCH=$(awk -F'=' '/defaultbranch/ {print $2}' src/kayobe-config/.gitreview)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a bug fix that would apply to yoga too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, but please backport this fix if necessary.

echo "openstack_release=${BRANCH}" | sed "s|stable/||" >> $GITHUB_OUTPUT

# Generate a tag to apply to all built overcloud host images.
Expand All @@ -67,7 +67,7 @@ jobs:

- name: Install dependencies
run: |
sudo dnf -y install zstd
sudo dnf -y install zstd debootstrap

- name: Setup networking
run: |
Expand All @@ -84,14 +84,6 @@ jobs:
sudo ip l set dummy1 up
sudo ip l set dummy1 master breth1

# FIXME: Without this workaround we see the following issue after the runner is power cycled:
# TASK [MichaelRigart.interfaces : RedHat | ensure network service is started and enabled] ***
# Unable to start service network: Job for network.service failed because the control process exited with error code.
# See \"systemctl status network.service\" and \"journalctl -xe\" for details.
- name: Kill dhclient (workaround)
run: |
(sudo killall dhclient || true) && sudo systemctl restart network

- name: Install Kayobe
run: |
mkdir -p venvs &&
Expand Down
4 changes: 2 additions & 2 deletions etc/kayobe/pulp-host-image-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
# Overcloud host image versioning tags
# These images must be in SMS, since they are used by our AIO CI runners
stackhpc_rocky_9_overcloud_host_image_version: "yoga-20230929T133006"
stackhpc_ubuntu_jammy_overcloud_host_image_version: "yoga-20230609T120720"
stackhpc_rocky_9_overcloud_host_image_version: "zed-20231013T123933"
stackhpc_ubuntu_jammy_overcloud_host_image_version: "zed-20231013T123933"