Set q35 hw machine type as default #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnasiadka
reviewed
Sep 18, 2023
etc/kayobe/kolla/config/nova.conf
Outdated
| @@ -0,0 +1,3 @@ | |||
| [libvirt] | |||
| hw_machine_type = q35 | |||
| num_pcie_ports = 16 | |||
There was a problem hiding this comment.
That's going to be backported upstream (right @bbezak ?) - so we probably could set only hw_machine_type?
There was a problem hiding this comment.
master got merged today. backports just started - https://review.opendev.org/c/openstack/kolla-ansible/+/895373
There was a problem hiding this comment.
Probably we should have kept this since we can't assume kolla-ansible is up to date on client deployments.
darmach
changed the title
bbezak
approved these changes
Sep 22, 2023
markgoddard
reviewed
Sep 27, 2023
| upgrade: | ||
| - | | ||
| Configure Nova to use more modern 'q35' libvirt machine type rather than | ||
| 'pc' which is considered legacy. |
There was a problem hiding this comment.
Will there be any impact on existing systems from changing this?
There was a problem hiding this comment.
Most likely no - in yoga all instances should have type metadata already, during upgrade check will fail if not. When restarted new vms should use new type afaik.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed nova.conf machine type to q35.