-
Notifications
You must be signed in to change notification settings - Fork 23
Add Openstack Capacity to StackHPC Kayobe Config #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2809a40
to
5ea22d2
Compare
I think we need two more things.
|
5ea22d2
to
de86f68
Compare
Current CI failures are just from a lack of space on SMS. As long as one of them passes, I think we an force push these changes through |
I would vote for some documentation, especially we require defined variables in secrets |
de86f68
to
122b64d
Compare
Updated the monitoring docs to include information on how to define secrets. |
Couple of tox docs errors but otherwise looks good |
122b64d
to
e3c65a3
Compare
Classic mistake 😅 |
We should merge the PR on smslab that is pending first and ensure all comments from there are addressed to avoid having two open PR's with different discussions @assumptionsandg |
5367e6f
to
737376f
Compare
Removed the playbook hook from service deploy to leave for manual deployment, as this exporter requires application credentials to be defined prior to deploying the exporter. |
I agree that we should resolve all the conversations, but I think it would be best to merge this one first, then sync smslab/yoga with skc/yoga so we don't end up with any merge weirdness. Or we could cherry-pick this commit to the SMS PR so the hash is the same which would have the same effect. Either way, best to get this through asap |
b38079c
to
f3d4351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few small things we could change with the documentation, and you could add a link in the release note to the relevant section, but I think we're hitting diminishing returns on polishing this PR. I'm happy with it as is
afacf82
to
9fa4307
Compare
Something funky seems to have happened to your rebase. Might need a bit of git untangling |
9fa4307
to
6739b7f
Compare
Not sure what happened with that rebase, should be good now though! 😄 |
@@ -0,0 +1,9 @@ | |||
{% raw %} | |||
scrape_configs: | |||
- job_name: os-capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail on a system with internal TLS. Requires this:
{% if kolla_enable_tls_internal | bool %}
scheme: https
{% endif %}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping this issue.
This patch adds Openstack Capacity to StackHPC Kayobe Config.