Skip to content

Reduce ESP partition size in deployment image #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

cityofships
Copy link
Member

@cityofships cityofships commented Oct 10, 2023

It does not fit into 550MiB partition created by Ironic Python Agent. This is relevant when provisioning software RAID UEFI enabled servers.

https://github.com/openstack/ironic-python-agent/blob/stable/yoga/ironic_python_agent/raid_utils.py#L30

@cityofships cityofships requested a review from a team as a code owner October 10, 2023 07:15
@cityofships cityofships requested a review from mnasiadka October 10, 2023 10:25
mnasiadka
mnasiadka previously approved these changes Oct 10, 2023
@cityofships cityofships enabled auto-merge (rebase) October 11, 2023 06:43
@markgoddard
Copy link
Contributor

Do we need new host images with this change included?

@cityofships
Copy link
Member Author

Do we need new host images with this change included?

Yes. Before that's available, one can either virt-customize local image or use IPA with ESP_SIZE_MIB modified to something bigger.

@cityofships
Copy link
Member Author

cityofships commented Oct 12, 2023

It does not fit into 550MiB partition created by Ironic Python Agent.
This is relevant when provisioning software RAID UEFI enabled servers.
@priteau
Copy link
Member

priteau commented Oct 18, 2023

Is this an upstream issue too? DIB defaults to 550 MiB and IPA too, but the DIB image doesn't fit into what IPA creates? Maybe IPA should be just slightly bigger?

@mnasiadka
Copy link
Member

Is this an upstream issue too? DIB defaults to 550 MiB and IPA too, but the DIB image doesn't fit into what IPA creates? Maybe IPA should be just slightly bigger?

I think it's rather the issue of our layout that we pass to DIB?

@mnasiadka
Copy link
Member

I'll rebuild the images as part of #721

@cityofships
Copy link
Member Author

Is this an upstream issue too? DIB defaults to 550 MiB and IPA too, but the DIB image doesn't fit into what IPA creates? Maybe IPA should be just slightly bigger?

I think it's rather the issue of our layout that we pass to DIB?

It's probably rounding / calculations error, I saw the ESP partition 0,1MB too big for MD created by IPA. It's easier to change here than a hard-coded value in IPA for us.

@mnasiadka mnasiadka disabled auto-merge October 26, 2023 08:07
@mnasiadka
Copy link
Member

Merging as this is not tested in aio

@mnasiadka mnasiadka merged commit 83a3c8f into stackhpc/yoga Oct 26, 2023
@mnasiadka mnasiadka deleted the fix_esp_sizing branch October 26, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants